Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mac build #8123

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Fixed mac build #8123

merged 1 commit into from
Sep 4, 2024

Conversation

xoriole
Copy link
Contributor

@xoriole xoriole commented Aug 29, 2024

Fixes #8121

This PR:

  • Defines an utility function to get the webui path
  • Updates pyinstaller tribler.spec to include ui files.

The pyinstaller build created with the changes is verified to work on the Mac mini (Intel) build machine.

@qstokkink
Copy link
Contributor

@xoriole do you mind if I push to your branch to have this PR pass the CI?

@xoriole
Copy link
Contributor Author

xoriole commented Sep 4, 2024

@xoriole do you mind if I push to your branch to have this PR pass the CI?

Please, go ahead

@qstokkink qstokkink marked this pull request as ready for review September 4, 2024 07:42
@qstokkink qstokkink changed the title Fix mac build READY: Fixed mac build Sep 4, 2024
@qstokkink qstokkink changed the title READY: Fixed mac build Fixed mac build Sep 4, 2024
@qstokkink qstokkink merged commit 4f6aaf6 into Tribler:main Sep 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Mac build does not run
3 participants