Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion to move start_discovery outside BamiCommunity #37

Open
devos50 opened this issue Oct 6, 2020 · 0 comments
Open

Suggestion to move start_discovery outside BamiCommunity #37

devos50 opened this issue Oct 6, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@devos50
Copy link
Collaborator

devos50 commented Oct 6, 2020

The start_discovery method contains logic to add a particular walking strategy to IPv8. This method, however, is currently not used anywhere in the BAMI module. It is used by the experiments, however, with the default arguments.

I wonder if it would be cleaner to move this method outside the start_discovery, e.g., to Gumby?
@devos50 devos50 added the enhancement New feature or request label Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@devos50