Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove numpy version pin when able #368

Open
kmohrman opened this issue Jun 6, 2023 · 3 comments
Open

Remove numpy version pin when able #368

kmohrman opened this issue Jun 6, 2023 · 3 comments

Comments

@kmohrman
Copy link
Contributor

kmohrman commented Jun 6, 2023

Note that we have pinned the numpy version in the environment.yml file (to numpy=1.23.5) as a workaround to the numpy.bool error that we otherwise get (from one of the coffea files). This is implemented in PR #354.

This should be revisited at some point (e.g. once coffea has fixed the numpy.bool instance, or once conda has figured out how to make a consistent environment that does not lead to this error) to remove the numpy version pin.

@bryates
Copy link
Contributor

bryates commented Mar 14, 2024

The numpy.bool issu was addressed in Coffea v0.7.22 scikit-hep/coffea#901. We can now unpin numpy.

@bryates bryates mentioned this issue Mar 14, 2024
@bryates bryates linked a pull request Mar 14, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In review to Done in Calendar Coffea roadmap Mar 14, 2024
@bryates
Copy link
Contributor

bryates commented Apr 2, 2024

There are still some issues with our repo and numpy, so I'm reopening this for later. (see #405)

@bryates bryates reopened this Apr 2, 2024
@bryates bryates moved this from Done to In review in Calendar Coffea roadmap Apr 2, 2024
@bryates bryates moved this from In review to Ready in Calendar Coffea roadmap Apr 2, 2024
@bryates bryates removed a link to a pull request May 22, 2024
@bryates
Copy link
Contributor

bryates commented Jun 20, 2024

Now there is an issue with numpy 2.0, so we'll have to keep this a bit longer. Hopefully the calendar coffea transition will eventually remove the need to pin numpy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

No branches or pull requests

2 participants