Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the year check outside of event_selection's trg_pass_no_overlap() #24

Open
kmohrman opened this issue Apr 2, 2024 · 0 comments
Open

Comments

@kmohrman
Copy link
Contributor

kmohrman commented Apr 2, 2024

Regarding this code:

    # The triggers for 2016 and 2016APV are the same
    if year == "2016APV":
        year = "2016"
    #The trigger list for 2022 and 2022EE are the same
    if year == "2022EE":
        year = "2022"

I think it would be better to handle this on the users' side (where the function is called) rather than inside of this function. The year is used when we use it as a key for the dataset dictionary (but the dataset dictionary is also passed to this function). So the handling of which year goes with which key should go on the user side, not hard coded within this function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant