New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_query method has odd returns #7

Open

TomFaulkner opened this issue Apr 15, 2017 · 1 comment

Owner

TomFaulkner commented Apr 15, 2017

_query method returns an output or false, this is likely better handled by an exception

The query method is used in many functions, would add a lot of exception handling. Perhaps return a boolean and the value / empty string

Owner Author

TomFaulkner commented Apr 15, 2017

Perhaps include a retry or two on queries as well. Though, this would slow things down if sending irrelevant queries to a device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment