v1.1.8: Fix skill proficiency path and add language removal

- Changed skill proficiency from .proficient to .value (correct property)
- Added removeLanguageFromActor method to properly remove languages
- Languages are now removed when cultural origin is changed
- Fixed skill not being applied despite logs showing it was set

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: TinyDragonEgg

module.json

@@ -2,7 +2,7 @@
   "id": "aspects-dual-backgrounds",
   "title": "Aspects of Verun: Dual Backgrounds",
   "description": "Enables dual background system for Aspects of Verun setting - choose one Profession background and one Cultural Origin background",
-  "version": "1.1.7",
+  "version": "1.1.8",
   "compatibility": {
     "minimum": "11",
     "verified": "13"
@@ -48,7 +48,7 @@
   ],
   "url": "https://github.com/TinyDragonEgg/testmodule",
   "manifest": "https://raw.githubusercontent.com/TinyDragonEgg/testmodule/main/module.json",
-  "download": "https://github.com/TinyDragonEgg/testmodule/releases/download/1.1.7/module.zip",
+  "download": "https://github.com/TinyDragonEgg/testmodule/releases/download/1.1.8/module.zip",
   "license": "MIT",
   "readme": "https://raw.githubusercontent.com/TinyDragonEgg/testmodule/main/README.md"
 }

scripts/dual-backgrounds.js

@@ -322,14 +322,14 @@ class DualBackgroundsManager {
 
       // Remove old skill proficiency
       if (oldCulturalOrigin && allOrigins[oldCulturalOrigin]?.skill) {
-        const oldSkillPath = `system.skills.${allOrigins[oldCulturalOrigin].skill}.proficient`;
+        const oldSkillPath = `system.skills.${allOrigins[oldCulturalOrigin].skill}.value`;
         foundry.utils.setProperty(changes, oldSkillPath, 0);
         this.log(`Removing old skill: ${allOrigins[oldCulturalOrigin].skill}`);
       }
 
       // Add new skill proficiency
       if (newCulturalOrigin && allOrigins[newCulturalOrigin]?.skill) {
-        const skillPath = `system.skills.${allOrigins[newCulturalOrigin].skill}.proficient`;
+        const skillPath = `system.skills.${allOrigins[newCulturalOrigin].skill}.value`;
         foundry.utils.setProperty(changes, skillPath, 1);
         this.log(`Adding skill proficiency in update: ${allOrigins[newCulturalOrigin].skill} at path ${skillPath}`);
         this.log(`Changes object after skill set:`, changes);
@@ -348,7 +348,7 @@ class DualBackgroundsManager {
   static async applyCulturalOriginFeatures(actor, newOrigin, oldOrigin) {
     this.log(`Applying cultural origin features: ${newOrigin} (was: ${oldOrigin})`);
 
-    // Remove old cultural origin features and equipment
+    // Remove old cultural origin features, equipment, and language
     if (oldOrigin) {
       const oldItems = actor.items.filter(item =>
         item.flags?.[this.ID]?.isCulturalOrigin
@@ -358,6 +358,12 @@ class DualBackgroundsManager {
         await actor.deleteEmbeddedDocuments('Item', oldItems.map(i => i.id));
         this.log(`Removed ${oldItems.length} old cultural origin items`);
       }
+
+      // Remove old language
+      const allOrigins = this.getAllCulturalOrigins();
+      if (oldOrigin && allOrigins[oldOrigin]?.languages) {
+        await this.removeLanguageFromActor(actor, allOrigins[oldOrigin].languages);
+      }
     }
 
     // Add new cultural origin
@@ -613,6 +619,46 @@ class DualBackgroundsManager {
     }
   }
 
+  /**
+   * Remove a language from an actor
+   */
+  static async removeLanguageFromActor(actor, languagesToRemove) {
+    if (!languagesToRemove || languagesToRemove.length === 0) return;
+
+    try {
+      // Get fresh actor data
+      const currentActor = game.actors.get(actor.id);
+      const currentLanguages = currentActor.system.traits?.languages?.value;
+
+      if (!currentLanguages) return;
+
+      let updatedLanguages = [];
+
+      // Convert language names to keys
+      const languageKeysToRemove = languagesToRemove.map(lang => lang.toLowerCase());
+
+      if (currentLanguages instanceof Set) {
+        // v5.2.4+ uses Set
+        updatedLanguages = Array.from(currentLanguages).filter(lang =>
+          !languageKeysToRemove.includes(lang) && !languageKeysToRemove.includes(lang.toLowerCase())
+        );
+        this.log(`Removed languages from Set:`, languageKeysToRemove);
+      } else if (Array.isArray(currentLanguages)) {
+        // Older versions use Array
+        updatedLanguages = currentLanguages.filter(lang =>
+          !languageKeysToRemove.includes(lang) && !languageKeysToRemove.includes(lang.toLowerCase())
+        );
+        this.log(`Removed languages from Array:`, languageKeysToRemove);
+      }
+
+      await currentActor.update({ 'system.traits.languages.value': updatedLanguages });
+      this.log(`Successfully removed languages:`, languagesToRemove);
+    } catch (err) {
+      this.log('Error removing languages:', err);
+      console.error(err);
+    }
+  }
+
   /**
    * Show language selection dialog
    */