Add modifiers to actions in the sequences

[freslep]

If I have an action that I only want completed if a mod button is pressed [mod] or a mod button is not pressed [nomod] it seams wasteful for GSE to send that macro if it is not needed (as the /casts have [nomod] on them for instance). If each action had an option to say whether to run when mod was pressed or when no mod was pressed or to run regardless it would result in less fluff being sent to wow to not actually do anything. However, I don't know if this would put GSE at odds with terms of service for wow regarding it being made a little smarter.

[TimothyLuke]

Running [nomod] is a waste of characters/ Has nothing to do with Terms of Service it has to do with the limit of 255 characters per action.

Personally there are less problems doing

/cast [mod:alt] Override Spell
/cast normal spell

than doing

/cast [nomod] normal spell
/cast [mod:alt] Override Spell

This last form is problematic and creates issues for you.

You can also simplify this further as

/cast [mod:alt] Override Spell; normal spell

SIgnificantly reducing characters.

[freslep]

You're right and I've used those techniques, but have run into issues due to reduced size of macros in the new world, I'll dig out an example. Was something that came to mind, but it is an edge use-case.

[freslep]

Say I had something like this. It's already using up a lot of macro space. The idea behind the macro is that I press a mod (ALT) when I want my cooldowns firing; trinkets, Avatar, Ravage, Thunderous Roar, Demoralizing Shout, Champion's Spear. I've actually changed my prot warrior setup to fire the cooldowns on a different button, but it makes the point I think. Shield Block, Avatar, and trinkets are all off the GCD so have been banged in every macro, but 4 of the major cooldowns need their own macro, so most of the time it would still be sending those 4 even when they were not really needed. The blank lines indicate the division between actions.

/targetenemy [noharm][dead]
/startattack
/cast Shield Charge
/cast [nostance:1,nostance:2] Defensive Stance
/cast Shield Block
/cast [combat,mod] Avatar
/use [combat,mod,@player] 13
/use [combat,mod,@player] 14

/targetenemy [noharm][dead]
/startattack
/cast Shield Slam
/cast [nostance:1,nostance:2] Defensive Stance
/cast Shield Block
/cast [combat,mod] Avatar
/use [combat,mod,@player] 13
/use [combat,mod,@player] 14

/targetenemy [noharm][dead]
/startattack
/cast [combat] Thunder Clap
/cast [nostance:1,nostance:2] Defensive Stance
/cast Shield Block
/cast [combat,mod] Avatar
/use [combat,mod,@player] 13
/use [combat,mod,@player] 14

/targetenemy [noharm][dead]
/startattack
/cast [nomod,combat,stance:2] Revenge; [nomod,combat] Ignore Pain
/cast [nostance:1,nostance:2] Defensive Stance
/cast Shield Block
/cast [combat,mod] Avatar
/use [combat,mod,@player] 13
/use [combat,mod,@player] 14

/targetenemy [noharm][dead]
/startattack
/cast Execute
/cast [nostance:1,nostance:2] Defensive Stance
/cast Shield Block
/cast [combat,mod] Avatar
/use [combat,mod,@player] 13
/use [combat,mod,@player] 14

/targetenemy [noharm][dead]
/startattack
/cast [combat,@player,mod] Ravager
/cast [nostance:1,nostance:2] Defensive Stance
/cast Shield Block
/cast [combat,mod] Avatar
/use [combat,mod,@player] 13
/use [combat,mod,@player] 14

/targetenemy [noharm][dead]
/startattack
/cast [combat,mod] Thunderous Roar
/cast [nostance:1,nostance:2] Defensive Stance
/cast Shield Block
/cast [combat,mod] Avatar
/use [combat,mod,@player] 13
/use [combat,mod,@player] 14

/targetenemy [noharm][dead]
/startattack
/cast [combat] Victory Rush
/cast [nostance:1,nostance:2] Defensive Stance
/cast Shield Block
/cast [combat,mod] Avatar
/use [combat,mod,@player] 13
/use [combat,mod,@player] 14

/targetenemy [noharm][dead]
/startattack
/cast [combat,mod] Demoralizing Shout
/cast [nostance:1,nostance:2] Defensive Stance
/cast Shield Block
/cast [combat,mod] Avatar
/use [combat,mod,@player] 13
/use [combat,mod,@player] 14

/targetenemy [noharm][dead]
/startattack
/cast [combat,mod] Champion's Spear
/cast [nostance:1,nostance:2] Defensive Stance
/cast Shield Block
/cast [combat,mod] Avatar
/use [combat,mod,@player] 13
/use [combat,mod,@player] 14

[TimothyLuke]

Shield Block, Avatar, and trinkets are all off the GCD so have been banged in every macro, but 4 of the major cooldowns need their own macro, so most of the time it would still be sending those 4 even when they were not really needed.

So what is the issue here?

[freslep]

Let's just take this block:

/targetenemy [noharm][dead]
/startattack
/cast [combat,mod] Champion's Spear
/cast [nostance:1,nostance:2] Defensive Stance
/cast Shield Block
/cast [combat,mod] Avatar
/use [combat,mod,@player] 13
/use [combat,mod,@player] 14

GSE sends that every time it gets to it even though I only really want it sent if I'm holding a modifier. That's the issue, especially when there are a number of blocks like that. For this sequence I was putting together I wanted all my CDs being sent when I presses mod, which it achieved at the expense of sending them through to wow even when mod was not pressed for wow's interpreter to say nothing going on here (except the target, startattack and shield block) as mod is not being pressed, so 4 of the 10 blocks just taking up processing time for no reason. Easiest solution for me was to put my "boost" spells on a different button.

[TimothyLuke]

It can’t choose what to send based on the modifier as GSE doesn’t evaluate it. Nor does GSE execute it. It just sends to wow which evaluates and executes. If you don’t include it you can’t send it.

[freslep]

My suggestion is that each action block in GSE gets a new option. At the moment each action block can be disabled with the Disable Block checkbox, my idea suggestion (sorry if I wasn't clear) is that there is perhaps a dropdown that says when GSE processes the action block, Always (the default), Never (same as Disable Block), a Modifier is being pressed, No Modifier is being pressed. That is if GSE can get that information during combat.

[TimothyLuke]

But GSE doesn’t (and in combat can’t) process the action block. In order to be able to do what it does it has to be blind to the content and just pass it along to WoW.

While it can see the modifiers as soon as it uses that information to do anything with the sequence it then has wow throw “Interface action blocked.” Errors And all of GSE shuts down till you end combat.

GSE has a total of 0 involvement with the execution of your sequence. All it does is when you click gets the next series of commands and sends them to WoW to do whatever it decides to do. It is extremely limited by what WoW allows in the restricted combat environment. These limits don’t affect WeakAuras for example as WA also doesn’t “do” anything. It just writes stuff to the screen and plays sounds so you the player decides to do something. WA however can’t pass stuff onto WoW to execute - GSE can.

[freslep]

ok makes sense thanks

[TimothyLuke]

You are sending startattack each block and its completely redundant but you are not worried about it

[freslep]

Thanks for pointing that out, if it was meant sarcastically, don't bother.

[TimothyLuke]

This isn’t sarcasm. The command only has a use if you are playing classic or a caster. There is no swing timer in retail and startattack is merged into the melee commands. Its 13 characters that absolutely do nothing.

[freslep]

ok thanks