Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prioritized experience replay #4

Open
JasAva opened this issue Apr 10, 2019 · 5 comments
Open

Add prioritized experience replay #4

JasAva opened this issue Apr 10, 2019 · 5 comments

Comments

@JasAva
Copy link

JasAva commented Apr 10, 2019

Thanks for the excellent implementations of multiple classic RL agents, I have tried some of them, worked very well.
Just curious, do you plan to add the prioritized experience replay to the DQN? I have tried to embed the openai baseline PER files (https://github.com/openai/baselines/blob/master/baselines/deepq/replay_buffer.py) to the current DQN, should be a really easy job, sadly it doesn't work very well, seems no obvious improvements against the vanilla DQN.
If you have any insights on this or have you tried some similar implementation, please let me know, really appreciate it.

@TianhongDai
Copy link
Owner

@jaceza Hi, no problem - I will try to work on the prioritized experience replay in the next week. Before that maybe you can check this implementation from: https://github.com/Kaixhin/Rainbow

@JasAva JasAva closed this as completed Apr 11, 2019
@JasAva JasAva reopened this Apr 11, 2019
@JasAva
Copy link
Author

JasAva commented Apr 11, 2019

Thanks so much, I have come across the Rainbow implementation and will continue to figure out where I did wrong. (Sorry for the accident close and reopen), keep me posted on your implementation. Thanks again.

@TianhongDai
Copy link
Owner

@jaceza Don't worry, no problem.

@TianhongDai
Copy link
Owner

TianhongDai commented May 6, 2019

@JasAva Sorry for the delay of the update, I need to focus on the deadline in the next following weeks. Then i will try to make a huge update to the repository. Firstly, i will write the pre-processing functions. In this case, we don't need to install openai baselines for their pre-processing functions. Secondly, update the PER for DQN algorithms. Sorry for I don't update the code in these period😣.

@JasAva
Copy link
Author

JasAva commented May 7, 2019

@TianhongDai No problem, thanks for letting me know, good luck with the deadline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants