Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video is not blocked #29

Open
Thunderarea opened this issue Jul 11, 2024 · 2 comments
Open

Video is not blocked #29

Thunderarea opened this issue Jul 11, 2024 · 2 comments
Labels
bug Something isn't working critical Critical bug

Comments

@Thunderarea
Copy link
Owner

After some recent changes on YouTube, the audio/video files of YouTube videos do not have a parameter mime=audio (or video). In this way, the extension cannot detect the audio files in order to put them in the player. Also, the video files are not detected in order to be blocked. Any contribution is more than welcome!

https://github.com/Thunderarea/music-mode-for-youtube/blob/6fa67b31a665255c549bcb205e29f6aa4ed35183/source/js/video_handler.js#L197C9-L197C48

@Thunderarea Thunderarea added bug Something isn't working critical Critical bug labels Jul 11, 2024
@Newcool1230
Copy link

Looking at the transfer sizes it seems like they've combined audio+video together most likely to serve built-in ads in the near future. You can however still get mime=audio and mime=video from the mobile browser version (m.youtube.com), this will probably change once they properly implement the audio+video version.

This might be the end of audio only youtube, unless there is something in the request body that can be changed...

@Heuingmin
Copy link

I'm wondering if is possible to use the worst video choice in force when enabling the blocking video function for the chrome extension? I know nothing about browser application nor javascript :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical Critical bug
Projects
None yet
Development

No branches or pull requests

3 participants