Good catch! Thanks, I’ll get that fixed tomorrow 🙂

@kick2nick - if I can get new packages published to our development package feed, would you be able to verify whether they resolve the issue for you?

Yes, I would be able

Can you try v2.5.11-develop.5?

Got this 😄 :
exceptions":["System.InvalidOperationException: This operation is not supported for a relative URI."," at System.Uri.get_Scheme()"," at System.UriBuilder.SetFieldsFromUri()"," at KubeClient.Utilities.UriHelper.SafeGetPathAndQuery(Uri uri)

Ok, that’s odd - I thought I’d tested it pretty thoroughly but perhaps the behaviour is different in PowerShell 🤷🏻

I’ll write up some unit tests and see what’s going on (System.Uri‘s handling of relative URIs is surprisingly bad).

Ugh, it is different in PowerShell (where I did my testing). Needs to be new UriBuilder(uri.OriginalString), not new UriBuilder(uri).

I’ll add some tests once I get to my computer; it seems there are a couple of unexpected quirks in the BCL’s handling of relative URIs 🙂

Ok, can you try v2.5.11-develop.7? There are a bunch of tests, now, for URI handling, so I'm pretty confident it should work correctly now (I'd integration-test this myself, but I don't have a working k8s cluster at the moment!).

Tested in k8s new version, watch request works as expected.
Log entry:
Start streaming \"GET\" request for \"/api/v1/watch/namespaces/%7BNamespace%7D/endpoints/%7BServiceName%7D\
It has no route params, but probably it's ok for debug log)

I’ll see what I can do about expanding the route parameters, but it may require an enhancement to the HTTP template library :)

It's your choice, but as far as I understand this bug impacts all watch requests in your library, so this enhancement could be part of separate PR if it need time.

Definitely agree; will leave that for later, but can at least make the logging conditional on the configured log level. Will publish a release version tomorrow morning.

Cool, thank you for quick fix!

BTW, I will probably remove that log statement (eventually) as KubeClient’s existing request/response logging will already include that populated URI.

Publishing v2.5.12...

@tintoy commented on Oct 16

Did you forget to tag the release as the latest one, or is it a pre-release?

Good catch! Done 🙂