Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle "Full Width" element (~20-30 stories total?) #252

Open
phillipadsmith opened this issue Jul 8, 2016 · 7 comments
Open

Handle "Full Width" element (~20-30 stories total?) #252

phillipadsmith opened this issue Jul 8, 2016 · 7 comments

Comments

@phillipadsmith
Copy link
Member

@MrBryan Some stories in the past used a "full width" element to break out of the two-column layout at the top of the story, typically for a very large illustration, map, or interactive.

Here's one example:
http://thetyee.ca/Opinion/2016/05/24/UBC-Let-Students-Live-on-Campus/

On the preview site that illustration is cropped incorrectly.

This would be another interesting story to check:
http://thetyee.ca/News/2012/07/04/CarbonFootprint/

In fact, all "full width" containing stories should get checked manually, I would propose.

Not launch-blocking, but problematic.

@phillipadsmith
Copy link
Member Author

Related, the "caption" element for this sub-element is probably different than the standard one, e.g.: nothing is appearing here: http://preview.thetyee.ca/Opinion/2016/05/24/UBC-Let-Students-Live-on-Campus/

@phillipadsmith
Copy link
Member Author

Another full width example, I think:
Side-by-side photo spacing
URL: http://preview.thetyee.ca/News/2016/05/25/Rise-of-Condos-Razed-Trees-Bird-Evictions/
Description: This story has side by side photos as the main art, and it’s creating an odd spacing issue with too much white space on top and bottom
Reporter: Jeanette

@MrBryan
Copy link
Collaborator

MrBryan commented Jul 11, 2016

Jeanette's one is that the image itself has a bunch of white space in it. ( so it just needs to be cropped differently i.e. without white space included)

@MrBryan
Copy link
Collaborator

MrBryan commented Jul 11, 2016

For the other one, the full width zone is going to have to be parsed, it's actually written in with html in the element

image

@MrBryan
Copy link
Collaborator

MrBryan commented Jul 11, 2016

Repreviewing the first one removed the empty quote which was fixed earlier

@phillipadsmith
Copy link
Member Author

Repreviewing the first one removed the empty quote which was fixed earlier

Not totally sure which one you're referring to here, but I'm still not seeing a caption under this image:
http://preview.thetyee.ca/Opinion/2016/05/24/UBC-Let-Students-Live-on-Campus/

In terms of the HTML in the full-width zone: Yes, that's correct, it was a kludge of a solution at the time ... and it's possible that those will need to be manually updated (as mentioned, I don't believe there are that many since its introduction).

Though, it does beg the (post-launch) question of using an actual full-width treatment for that content. @alexgreen Do we still have a full, edge-to-edge, treatment available? I.e., could this content -- not necessarily and image; could be a map or interactive -- work elsewhere on the page?

@phillipadsmith
Copy link
Member Author

This story is still wonky, FYI: http://preview.thetyee.ca/News/2012/07/04/CarbonFootprint/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants