-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle "Full Width" element (~20-30 stories total?) #252
Comments
Related, the "caption" element for this sub-element is probably different than the standard one, e.g.: nothing is appearing here: http://preview.thetyee.ca/Opinion/2016/05/24/UBC-Let-Students-Live-on-Campus/ |
Another full width example, I think: |
Jeanette's one is that the image itself has a bunch of white space in it. ( so it just needs to be cropped differently i.e. without white space included) |
Repreviewing the first one removed the empty quote which was fixed earlier |
Not totally sure which one you're referring to here, but I'm still not seeing a caption under this image: In terms of the HTML in the full-width zone: Yes, that's correct, it was a kludge of a solution at the time ... and it's possible that those will need to be manually updated (as mentioned, I don't believe there are that many since its introduction). Though, it does beg the (post-launch) question of using an actual full-width treatment for that content. @alexgreen Do we still have a full, edge-to-edge, treatment available? I.e., could this content -- not necessarily and image; could be a map or interactive -- work elsewhere on the page? |
This story is still wonky, FYI: http://preview.thetyee.ca/News/2012/07/04/CarbonFootprint/ |
@MrBryan Some stories in the past used a "full width" element to break out of the two-column layout at the top of the story, typically for a very large illustration, map, or interactive.
Here's one example:
http://thetyee.ca/Opinion/2016/05/24/UBC-Let-Students-Live-on-Campus/
On the preview site that illustration is cropped incorrectly.
This would be another interesting story to check:
http://thetyee.ca/News/2012/07/04/CarbonFootprint/
In fact, all "full width" containing stories should get checked manually, I would propose.
Not launch-blocking, but problematic.
The text was updated successfully, but these errors were encountered: