Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make machines have an editor location #27

Open
tatjam opened this issue Sep 20, 2020 · 2 comments
Open

Make machines have an editor location #27

tatjam opened this issue Sep 20, 2020 · 2 comments
Assignees
Labels
editor Issues related to the vehicle editor enhancement New feature or request

Comments

@tatjam
Copy link
Collaborator

tatjam commented Sep 20, 2020

This will improve editor usability as machines will have a logical position within the piece. We may leave the standard centered "polygon" mode for machines which have no position.

Implementation:
Add a new entry to the Machine class which indicates a marker assigned to said machine. This may not be present. The editor then must properly position the piece.
Visibility could be implemented piece-wise or machine-wise, this requires some testing to find the most comfortable solution.

@tatjam tatjam added the enhancement New feature or request label Sep 20, 2020
@tatjam tatjam self-assigned this Sep 20, 2020
@tatjam tatjam added the editor Issues related to the vehicle editor label Sep 20, 2020
@tatjam
Copy link
Collaborator Author

tatjam commented Sep 20, 2020

Something to keep in mind too is that the machine must still be clearly linked to the part it's on. Maybe an highlighting effect will be enough, otherwise some kind of indicator may be needed

@tatjam
Copy link
Collaborator Author

tatjam commented Sep 20, 2020

After adding this it has become evident that the editor needs some kind of click masking. I believe the most efficient way would be to simply let the machine closest to the camera get the click.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor Issues related to the vehicle editor enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant