New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inefficent string concatination #22

Open

jonesmz opened this issue Jun 6, 2020 · 0 comments

Labels

code-improvement good first issue

Member

jonesmz commented Jun 6, 2020 •

edited

Loading

const std::string fix_key = "_IKEY";
auto n_parse = SerializeUtil::load_string(fix_key + "=" + value);

change fix_key to std::string_view, or "static constexpr auto[]"
Concatinating strings like this is expensive. Take a look here: https://github.com/splinter-build/splinter/blob/15-default-values/src/string_concat.h

tatjam added code-improvement good first issue labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment