N/A: Light/dark Odin theme code block style

[dsmchen]

Checks

• This is not a duplicate of an existing issue (please have a look through our open issues list to make sure)
• I have thoroughly read and understand The Odin Project Contributing Guide
• Would you like to work on this issue?

Describe your suggestion

Current
Code block style is the same for the light/dark Odin theme.

Expected
Code block style is different depending on the light/dark Odin theme.

Screenshots

Path

Other / NA

Lesson Url

https://www.theodinproject.com/lessons/node-path-react-new-setting-up-a-react-environment#creating-a-react-app

(Optional) Discord Name

doris6601

(Optional) Additional Comments

No response

[KevinMulhern]

Thanks for the suggestion @dsmchen. Can you add some more context to this please? why do you think we need this change?

[dsmchen]

@KevinMulhern Thanks for your questions. We need this change because it seems to be a missing part of the light/dark Odin theme. For example:

MDN

Josh W. Comeau

freeCodeCamp

[KevinMulhern]

Thanks @dsmchen. IIRC having the same code block styles in all themes was something we choose to do instead of something that was missed. It looks good on both, keeps them consistent, and is less for us to maintain.

IMO this isn't worth changing unless theres an accessibility issue with contrast.

[dsmchen]

@KevinMulhern Ah I see. There isn't an accessibility issue with contrast. However, there's aesthetic value to improve the overall user experience. Perhaps this could be a low-priority issue that is addressed later?

[KevinMulhern]

Aesthetic value can be very subjective with things like this. Some people might prefer the lighter background, but many more might like it the way it is.

They way we usually handle things like this is move them to a discussion and revisit if it gets more engagement from people wanting the change.