Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Tracking #4

Open
1 of 11 tasks
The-Voidwalker opened this issue Feb 23, 2025 · 0 comments
Open
1 of 11 tasks

Misc Tracking #4

The-Voidwalker opened this issue Feb 23, 2025 · 0 comments

Comments

@The-Voidwalker
Copy link
Owner

The-Voidwalker commented Feb 23, 2025

  • After a4f5137 verify the changes to SSL.Read won't accidentally prevent OpenSSLHttpHandler.TryReadBlock from functioning.
  • BIO.CreateSocketInternal Cleanup handling should be improved.
  • OpenSSLHttpHandler.SendAsync SSL objects should be pooled and reused where possible. This will also require making SSL methods thread safe.
  • OpenSSLHttpHandler.SendAsync Ensure proper spacing between request headers and content. Validate number of newlines at end of content.
  • OpenSSLHttpHandler.SendAsync Check if linked TODO is valid or remove.
  • OpenSSLHttpHandler.SendAsync Verify if checking for Content-Type header is all that needs to be done to see if there will be response content.
  • OpenSSLHttpHandler.SendAsync After reading a Content-Length sized block, verify there is no further content. SSL.HasPending?
  • OpenSSLHttpHandler.SendAsync Change exception message under linked TODO
  • OpenSSLHttpHandler.SendAsync See if it's possible to create response.Content before we read the content (ideally before ParseHeaders is called, so we can skip the need to return content headers separately). Will need to make sure that this way of handling it won't cause problems by writing content after the fact.
  • OpenSSLHttpHandler.TryReadBlock SSL.Read gives each TCP record one by one unless we have read ahead set. We can therefore likely use smaller buffers.
  • OpenSSLHttpHandler.TryReadBlock Improve handling of situations where the connection has been closed during/at the end of reading.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant