Removed useless field in Utf8String

Author: TechPizzaDev

MCServerSharp.Base/Text/EncodingExtensions.cs

@@ -0,0 +1,15 @@
+using System;
+using System.Text;
+
+namespace MCServerSharp
+{
+    public static class EncodingExtensions
+    {
+        public static byte[] GetBytes(this Encoding encoding, ReadOnlySpan<char> text)
+        {
+            byte[] buffer = new byte[encoding.GetByteCount(text)];
+            _ = encoding.GetBytes(text, buffer);
+            return buffer;
+        }
+    }
+}

MCServerSharp.Base/Text/Utf8String/Utf8String.cs

@@ -18,9 +18,8 @@ namespace MCServerSharp
     [SkipLocalsInit]
     public partial class Utf8String : IComparable<Utf8String>, IEquatable<Utf8String>, ILongHashable
     {
-        public static Utf8String Empty { get; } = new Utf8String(Array.Empty<byte>());
+        public static Utf8String Empty { get; } = new Utf8String(ReadOnlyMemory<byte>.Empty);
 
-        private byte[]? _byteArray;
         private ReadOnlyMemory<byte> _bytes;
 
         public ReadOnlySpan<byte> Bytes => _bytes.Span;
@@ -30,39 +29,26 @@ public partial class Utf8String : IComparable<Utf8String>, IEquatable<Utf8String
 
         #region Constructors
 
-        private Utf8String(byte[] bytes)
-        {
-            _byteArray = bytes;
-            _bytes = _byteArray.AsMemory();
-        }
-
         private Utf8String(ReadOnlyMemory<byte> bytes)
         {
             _bytes = bytes;
         }
 
-        private Utf8String(int length) : this(length == 0 ? Array.Empty<byte>() : new byte[length])
-        {
-        }
-
-        public Utf8String(string value) : this(StringHelper.Utf8.GetByteCount(value))
+        public Utf8String(string value) : this(StringHelper.Utf8.GetBytes(value).AsMemory())
         {
-            StringHelper.Utf8.GetBytes(value, _byteArray);
         }
 
-        public Utf8String(ReadOnlySpan<char> chars) : this(StringHelper.Utf8.GetByteCount(chars))
+        public Utf8String(ReadOnlySpan<char> utf16) : this(StringHelper.Utf8.GetBytes(utf16).AsMemory())
         {
-            StringHelper.Utf8.GetBytes(chars, _byteArray);
         }
 
-        public Utf8String(ReadOnlySpan<byte> bytes) : this(bytes.Length)
+        public Utf8String(ReadOnlySpan<byte> utf8) : this(utf8.ToArray().AsMemory())
         {
-            bytes.CopyTo(_byteArray);
         }
 
         #endregion
 
-        public static Utf8String UnsafeWrap(ReadOnlyMemory<byte> data)
+        public static Utf8String WrapUnsafe(ReadOnlyMemory<byte> data)
         {
             return new Utf8String(data);
         }
@@ -74,28 +60,13 @@ public static Utf8String Create(ReadOnlySpan<byte> utf8)
             return new Utf8String(utf8);
         }
 
-        public static Utf8String Create(ReadOnlyMemory<byte> utf8)
-        {
-            return Create(utf8.Span);
-        }
-
-        public static Utf8String Create(Utf8Memory utf8)
-        {
-            return Create(utf8.Span);
-        }
-
         public static Utf8String Create(ReadOnlySpan<char> utf16)
         {
             if (utf16.IsEmpty)
                 return Empty;
             return new Utf8String(utf16);
         }
 
-        public static Utf8String Create(ReadOnlyMemory<char> utf16)
-        {
-            return Create(utf16.Span);
-        }
-
         public static Utf8String Create<TState>(
             int length, TState state, SpanAction<byte, TState> action)
         {
@@ -105,8 +76,9 @@ public static Utf8String Create<TState>(
             if (length == 0)
                 return Empty;
 
-            var str = new Utf8String(length);
-            action.Invoke(str._byteArray, state);
+            byte[] buffer = new byte[length];
+            var str = new Utf8String(buffer.AsMemory());
+            action.Invoke(buffer, state);
             return str;
         }
 
@@ -244,9 +216,9 @@ public static Utf8String Concat(ReadOnlySpan<byte> value1, ReadOnlySpan<byte> va
             dst = dst[value2.Length..];
 
             value3.CopyTo(dst);
-            dst = dst[value3.Length..];
+            //dst = dst[value3.Length..];
 
-            return new Utf8String(bytes);
+            return new Utf8String(bytes.AsMemory());
         }
 
         public static Utf8String Concat(Utf8String? value1, Utf8String? value2, Utf8String? value3)