perform recoil only once

Author: geneotech

src/game/detail/inventory/generate_equipment.h

@@ -49,7 +49,7 @@ entity_id requested_equipment::generate_for_impl(
 
 	auto recoils = perform_recoils;
 
-	auto transfer = [recoils, &cosm, &on_step, &max_effects_played](const auto from, const auto to, const bool play_effects = true) {
+	auto transfer = [&recoils, &cosm, &on_step, &max_effects_played](const auto from, const auto to, const bool play_effects = true) mutable {
 		if (to.dead()) {
 			return;
 		}
@@ -67,6 +67,7 @@ entity_id requested_equipment::generate_for_impl(
 		request.params.play_transfer_sounds = max_effects_played > 0 && play_effects;
 		request.params.play_transfer_particles = max_effects_played > 0 && play_effects;
 		request.params.perform_recoils = recoils;
+		recoils = false;
 
 		const auto result = perform_transfer_no_step(request, cosm);
 

src/game/modes/arena_mode.cpp

@@ -919,6 +919,7 @@ bool arena_mode::give_bomb_to_random_player(const input_type in, const logic_ste
 
 			auto request = item_slot_transfer_request::standard(spawned_bomb.get_id(), typed_player[t].get_id());
 			request.params.bypass_mounting_requirements = true;
+			request.params.perform_recoils = false;
 			perform_transfer(request, step);
 			break;
 		}

src/view/rendering_scripts/illuminated_rendering.cpp

@@ -423,11 +423,11 @@ void illuminated_rendering(const illuminated_rendering_input in) {
 			const vec2 projection_space_pos = cone.to_screen_space(world_space_pos);
 
 			float maximum_heat = 0.0f;
+			maximum_heat = std::max(maximum_heat, std::abs(it.template get<components::crosshair>().recoil.rotation));
 
 			for (const auto& gun_id : it.get_wielded_guns())
 			{
 				(void)gun_id;
-				maximum_heat = std::max(maximum_heat, std::abs(it.template get<components::crosshair>().recoil.rotation));
 			}
 
 			if (settings.crosshair.type == crosshair_type::CIRCULAR) {