Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choke point at FeatureDictWeighter.countFeature() with large numbers of threads #12

Open
krivard opened this issue Mar 11, 2016 · 0 comments

Comments

@krivard
Copy link
Member

krivard commented Mar 11, 2016

When querying a trained model, ProPPR uses a couple of bloom filters to track the trained and untrained features it encounters. This helps prevent mistakes where the wrong parameter file is used, or where the training set isn't representative of the test set.

Problem is, the bloom filter impl we're using blocks on key comparisons. It's a fast check, so we don't see much slowdown with --threads up to 32, but beyond that the thread blocking gets prohibitive.

Not sure what to do about this yet other than give you an option to disable it (which would obvs make it into people's default settings and defeat the whole purpose).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant