Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-NIF CRC algorithm Implementation #37

Open
5 tasks
TattdCodeMonkey opened this issue Aug 26, 2020 · 0 comments
Open
5 tasks

non-NIF CRC algorithm Implementation #37

TattdCodeMonkey opened this issue Aug 26, 2020 · 0 comments
Milestone

Comments

@TattdCodeMonkey
Copy link
Owner

TattdCodeMonkey commented Aug 26, 2020

For small binaries an elixir implementation can be more performant especially for nerves devices.

If we implement non-NIF version for CRC algorithm we could add an optional parameter to use the non-NIF calculation for users who know their payloads are small and would prefer to not load the NIF.

During implementation we have the NIFs to unit test against.

If useful we could also look at adding an optional threshold param to use vs not use the NIF.

Goals:

  • pure elixir CRC algorithm implementation
  • Support for all models the NIF supports.
  • Unit test elixir calculation with NIF implementation.
  • crc/2 & calculate/2 takes optional param to choose not to use NIF, should default to current behavior of using NIF
  • ☝️ default switched to not use NIF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant