-
Notifications
You must be signed in to change notification settings - Fork 2
fix component text corruption in duplicate dialog #1448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix component text corruption in duplicate dialog #1448
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8470ca4 to
02da690
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a smart and comprehensive solution. Nice!
For clarity: which GitHub issues is this specifically trying to fix?
Also: I notice I can overwrite any component in the library by entering an identical name into the duplicate dialog and using "import as new"
| return { | ||
| text, | ||
| digest: await generateDigest(text), | ||
| name: newName, | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT:
const digest = await generateDigest(text);
return {
text,
digest,
name: newName,
};
02da690 to
80ed20c
Compare
camielvs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still unable to reproduce the original issue on master or production. But nonetheless, on this branch I see things are a little more stable for edited components. LGTM
Merge activity
|
80ed20c to
1adebc1
Compare

Description
Closes #1403
Refactored component duplication and library management to use hydrated component references. This PR eliminates the need to repeatedly serialize/deserialize components with
js-yaml.Key changes:
replaceComponentNamehelper function to modify component names directly in the textComponentDuplicateDialogto work with hydrated componentsFavoriteComponentToggleto hydrate components before adding them to the libraryType of Change
Checklist
Test Instructions
Screen Recording 2025-12-01 at 8.29.44 PM.mov (uploaded via Graphite)
#1 like comments)Notes