Commit 011aa55
authored
Fix Sidebar Button being left behind when collapsed (#1441)
## Description
<!-- Please provide a brief description of the changes made in this pull request. Include any relevant context or reasoning for the changes. -->
Fix a bug where closing the sidebar then navigating to another pipeline results in the sidebar icon being detached from the sidebar.
Side note: The `Sidebar` component and associated provider etc needs cleaning up. Are we actually intending to use this or do our own custom thing?
## Related Issue and Pull requests
<!-- Link to any related issues using the format #<issue-number> -->
Closes Shopify/oasis-frontend#365
## Type of Change
<!-- Please delete options that are not relevant -->
- [x] Bug fix
## Checklist
<!-- Please ensure the following are completed before submitting the PR -->
- [ ] I have tested this does not break current pipelines / runs functionality
- [ ] I have tested the changes on staging
## Screenshots (if applicable)
<!-- Include any screenshots that might help explain the changes or provide visual context -->
## Test Instructions
<!-- Detail steps and prerequisites for testing the changes in this PR -->
## Additional Comments
<!-- Add any additional context or information that reviewers might need to know regarding this PR -->1 parent a5db934 commit 011aa55
File tree
1 file changed
+7
-8
lines changed1 file changed
+7
-8
lines changedLines changed: 7 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | 1 | | |
4 | 2 | | |
5 | 3 | | |
6 | 4 | | |
| 5 | + | |
7 | 6 | | |
8 | 7 | | |
9 | 8 | | |
| |||
12 | 11 | | |
13 | 12 | | |
14 | 13 | | |
15 | | - | |
| 14 | + | |
16 | 15 | | |
17 | 16 | | |
18 | 17 | | |
19 | | - | |
| 18 | + | |
20 | 19 | | |
21 | 20 | | |
22 | 21 | | |
23 | 22 | | |
24 | 23 | | |
25 | 24 | | |
26 | 25 | | |
27 | | - | |
| 26 | + | |
28 | 27 | | |
29 | 28 | | |
30 | 29 | | |
| |||
33 | 32 | | |
34 | 33 | | |
35 | 34 | | |
36 | | - | |
37 | | - | |
38 | | - | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
39 | 38 | | |
40 | 39 | | |
41 | 40 | | |
| |||
0 commit comments