Skip to content

Commit 6a9901c

Browse files
committed
fix scroll e2e
1 parent 0574e9c commit 6a9901c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

packages/solid-router/src/Transitioner.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,11 +108,11 @@ export function Transitioner() {
108108
),
109109
)
110110

111-
Solid.createRenderEffect(
111+
Solid.createComputed(
112112
Solid.on(
113113
[isPagePending, previousIsPagePending],
114114
([isPagePending, previousIsPagePending]) => {
115-
// emit onBeforeRouteMount
115+
// emit onBeforeRouteMount - using createComputed to run before component render effects
116116
if (previousIsPagePending.previous && !isPagePending) {
117117
router.emit({
118118
type: 'onBeforeRouteMount',

0 commit comments

Comments
 (0)