-
Notifications
You must be signed in to change notification settings - Fork 49
feat: Christmas tooling update 🎅🏼 #2295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset(s) detectedThis PR includes changeset(s) for the following changed packages: Not sure what this means? Click here to learn what changesets are. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
UrbanWill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ho Ho Ho Talisman engineering xmas is finally here! 🎅
I am very happy to see these changes going in, code looks good and everything works as expected.
Only one minor thing, import warnings. Eg: Libs like "@talismn/util" or "@talismn/icons" and some type imports here and there. Perhaps a biome config missing?
UrbanWill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous issues fixed by running pnpm build:packages
This PR replaces our test/build pipeline:
Important:
Note: hot reloading (rebuilding) the background script is pretty long for now, like 10+ seconds. it can be improved in another "big bang refactor" PR after this one is merged. it will require separating code that is background-only and code that needs to be shared by frontend and background, in 2 separate packages, so wxt can treeshake background script more efficiently.
Misc:
pnpm typecheckscript, which is now included in CIpnpm checkthat performs biome checks on files that are different from target branch