Skip to content

Remove from_tabular_file in ArrowDataset #273

@mariosasko

Description

@mariosasko

ArrowDataset.from_tabular_file is similar to TabularDataset's __init__. I think it's safe to remove this function. The same effect can be achieved with:

ArrowDataset.from_dataset(TabularDataset(...), ...)

E.g. #267 introduced some changes to TabularDataset's __init__ and this logic was not added to ArrowDataset. By deleting from_tabular_file, we won't have such problems in the future.

cc @ivansmokovic @mttk @FilipBolt

Metadata

Metadata

Assignees

No one assigned

    Labels

    datasetIssues or pull requests related to datasets

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions