Skip to content

Fix callbacks for AS #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tolauwae opened this issue Aug 11, 2023 · 1 comment · May be fixed by #197
Open

Fix callbacks for AS #201

tolauwae opened this issue Aug 11, 2023 · 1 comment · May be fixed by #197
Assignees
@tolauwae

Comments

@tolauwae
Copy link
Member

tolauwae commented Aug 11, 2023 •
edited
Loading

AS no longer passes the tidx of callbacks directly.
Instead, it saves the tidx in the linear memory and passes the index/address in memory as the reference for the callbacks.

This behaviour differs from Rust.
@tolauwae tolauwae converted this from a draft issue Aug 11, 2023
@tolauwae tolauwae linked a pull request Aug 11, 2023 that will close this issue
🔬 Load tidx for callbacks from memory #197
Draft
@tolauwae tolauwae added the bug label Aug 11, 2023
@tolauwae tolauwae self-assigned this Aug 22, 2023
@tolauwae tolauwae moved this to In Progress in WARDuino Roadmap Aug 22, 2023
@tolauwae tolauwae moved this from In Progress to Todo in WARDuino Roadmap Oct 6, 2023
@tolauwae tolauwae mentioned this issue Nov 21, 2024
Open
@tolauwae
Copy link
Member Author

Can also be fixed in AssemblyScript:

callback(function.index)

@tolauwae tolauwae removed the bug label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tolauwae tolauwae

Labels
None yet
Projects
WARDuino Roadmap
Status: Scheduled
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🔬 Load tidx for callbacks from memory TOPLLab/WARDuino
1 participant
@tolauwae