Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support asynchronous serializers #132

Closed
wants to merge 1 commit into from
Closed

Conversation

Airblader
Copy link
Collaborator

closes #93

Open Points:

  • Documentation
  • Tests
  • Deal with the race condition problem?

This pull request relates to or closes the following issues: #93

I have verified that…

  • the commits in this pull request follow the conventionalcommits pattern
  • tests have been updated or added
  • documentation has been updated to reflect the changes made

Complimenting our previous work on asynchronous deserializers, we now also
support asynchronous serializers by returning an observable.

closes #93

Signed-off-by: Ingo Bürk <[email protected]>
@alexey-anufriev
Copy link
Contributor

Got a case where this feature is actually would be quite handy. Currently I have to do that manually after the deserializer pass. Are there are plans with regards to the final implementation of this functionality?

@Airblader
Copy link
Collaborator Author

@alexey-anufriev Yeah, we can get this finished. I think we can ignore the race condition problem for now (and document it as a warning), leaving only tests & documentation to be done. Would you be interested in finishing that up? Otherwise I'll just have to find some time to do it, but I think it makes sense to get this done.

@Airblader Airblader force-pushed the master branch 2 times, most recently from ed654b7 to 2c0f93f Compare January 19, 2020 08:15
@Airblader Airblader closed this Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asynchronous (de-)serializers
2 participants