Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asynchronous (de-)serializers #93

Open
Airblader opened this issue Feb 19, 2019 · 2 comments
Open

Asynchronous (de-)serializers #93

Airblader opened this issue Feb 19, 2019 · 2 comments
Assignees
@Airblader
Labels
Comp: Core Core functionality of ngqp Priority: Medium Users can work without this for now, but this should be fixed soon-ish Status: Discussion We're not yet sure whether or how to implement this feature Type: Feature If you want to add something that doesn't exist yet

Comments

@Airblader
Copy link
Collaborator

Airblader commented Feb 19, 2019 •
edited
Loading

What's your idea?

(De-)serializers are currently synchronous, but it could make sense to have them be async. This we should consider allowing this.

Describe the solution you'd like

Have them return either a synchronous value or an observable.

Additional context

We need to investigate and discuss this first as this might introduce some questions.

Update 2019/04/26: Asynchronous deserializers are implemented now.
@Airblader Airblader added Type: Feature If you want to add something that doesn't exist yet Status: Discussion We're not yet sure whether or how to implement this feature Comp: Core Core functionality of ngqp Priority: Medium Users can work without this for now, but this should be fixed soon-ish labels Feb 19, 2019
@Airblader
Copy link
Collaborator Author

If implemented, we should explicitly define & document whether we react on first emission or completion of the returned observable.

@Airblader
Copy link
Collaborator Author

I think the biggest use-case here is deserializers being asynchronous, so we could also focus on only making those asynchronous for now.

For serializers due to CVAs not being reactive we could run into race conditions that we cannot avoid from ngqp.

Airblader added a commit that referenced this issue Apr 12, 2019
@Airblader
feat(core): support asynchronous deserializers
5fa8489 
We now support deserializers which run asynchronously by returning an
observable instead. This is useful when the deserializer relies on some
asynchronous process or data which has to be fetched first.

relates #93

Signed-off-by: Ingo Bürk <[email protected]>
@Airblader Airblader mentioned this issue Apr 12, 2019
Closed
10 tasks
@Airblader Airblader self-assigned this Apr 12, 2019
@Airblader Airblader mentioned this issue Apr 12, 2019
Merged
10 tasks
Airblader added a commit that referenced this issue Apr 12, 2019
@Airblader
feat(core): support asynchronous deserializers
6e1db1b 
We now support deserializers which run asynchronously by returning an
observable instead. This is useful when the deserializer relies on some
asynchronous process or data which has to be fetched first.

relates #93

Signed-off-by: Ingo Bürk <[email protected]>
Airblader added a commit that referenced this issue Apr 12, 2019
@Airblader
feat(core): support asynchronous deserializers
4722ca3 
We now support deserializers which run asynchronously by returning an
observable instead. This is useful when the deserializer relies on some
asynchronous process or data which has to be fetched first.

relates #93

Signed-off-by: Ingo Bürk <[email protected]>
Airblader added a commit that referenced this issue Apr 12, 2019
@Airblader
feat(core): support asynchronous deserializers
c7261a1 
We now support deserializers which run asynchronously by returning an
observable instead. This is useful when the deserializer relies on some
asynchronous process or data which has to be fetched first.

relates #93

Signed-off-by: Ingo Bürk <[email protected]>
Airblader added a commit that referenced this issue Apr 26, 2019
@Airblader
feat(core): support asynchronous deserializers
90a0709 
We now support deserializers which run asynchronously by returning an
observable instead. This is useful when the deserializer relies on some
asynchronous process or data which has to be fetched first.

relates #93

Signed-off-by: Ingo Bürk <[email protected]>
Airblader added a commit that referenced this issue Apr 26, 2019
@Airblader
feat(core): support asynchronous deserializers
428e266 
We now support deserializers which run asynchronously by returning an
observable instead. This is useful when the deserializer relies on some
asynchronous process or data which has to be fetched first.

relates #93

Signed-off-by: Ingo Bürk <[email protected]>
Airblader added a commit that referenced this issue Apr 26, 2019
@Airblader
feat(core): support asynchronous serializers
7a30871 
Complimenting our previous work on asynchronous deserializers, we now also
support asynchronous serializers by returning an observable.

closes #93

Signed-off-by: Ingo Bürk <[email protected]>
@Airblader Airblader mentioned this issue Apr 26, 2019
Closed
6 tasks
Airblader added a commit that referenced this issue May 10, 2019
@Airblader
feat(core): support asynchronous serializers
5221048 
Complimenting our previous work on asynchronous deserializers, we now also
support asynchronous serializers by returning an observable.

closes #93

Signed-off-by: Ingo Bürk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Airblader Airblader

Labels
Comp: Core Core functionality of ngqp Priority: Medium Users can work without this for now, but this should be fixed soon-ish Status: Discussion We're not yet sure whether or how to implement this feature Type: Feature If you want to add something that doesn't exist yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): support asynchronous serializers TNG/ngqp
1 participant
@Airblader