Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ControlValueAccessor for native <select> not working on initial pass #115

Open
Airblader opened this issue Mar 17, 2019 · 1 comment
Open

ControlValueAccessor for native <select> not working on initial pass #115

Airblader opened this issue Mar 17, 2019 · 1 comment
Labels
Comp: Core Core functionality of ngqp good first issue Good for newcomers Priority: Medium Users can work without this for now, but this should be fixed soon-ish Status: Needs Triage We need to properly tag this issue Type: Bug Something that should work doesn't

Comments

@Airblader
Copy link
Collaborator

What does the bug look like?

When using a native <select> and emptyOn, the initial sync from the route does not work correctly. It seems like in the ControlValueAccessor's writeValue everything is working as it should, but somehow the option does not appear selected.

Wrapping the setProperty call into a Promise.resolve().then() fixes the issue, but of course this is a last straw kind of thing.

We should check if our implementation deviates from others in this instance.
@Airblader Airblader added Type: Bug Something that should work doesn't good first issue Good for newcomers Comp: Core Core functionality of ngqp Priority: Medium Users can work without this for now, but this should be fixed soon-ish Status: Needs Triage We need to properly tag this issue labels Mar 17, 2019
@Airblader
Copy link
Collaborator Author

It would also be good to check if this issue can be reproduced with Angular Forms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Comp: Core Core functionality of ngqp good first issue Good for newcomers Priority: Medium Users can work without this for now, but this should be fixed soon-ish Status: Needs Triage We need to properly tag this issue Type: Bug Something that should work doesn't
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Airblader