refactor(v3): reorganize styles per client library #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(djangocms-blog): pagination
* feat(pagination): WIP See `TODO` and `XXX`
- 🚧 bootstrap4 .pagination
- ✅ default
- 🐞 tacc (CMS/Portal)
- UI bugs
- consider combining
- ✅ djangocms-blog .pagination
- ❌ TACC .c-page
- deleted out of ignorance
- must be restored
- reference provided
* fix(pagination): skin (color, border, outline, …)
- 💡 bootstrap4 .pagination
- ✅ default
- ✅ tacc (CMS/Portal)
- 💡 consider combining
- ✅ djangocms-blog .pagination
- ❌ TACC .c-page
- deleted out of ignorance
- must be restored
- reference provided
* refactor(pagination): link vs link--end
* docs(pagination): TODO @import x-link x-button
* refactor(pagination): __item & __link → vs __…-item & __…-link
* fix(pagination): skipped bootstrap link blue
* chore(pagination): re-order style and remove cruft
* fix(pagination): button (as link) looses width
* refactor(pagination): assume links are <a>
* enhance(pagination): edge cases
* fix(pagination): cms & portal match but are split
* fix(pagination): easy button links & square links
* fix(c-page): restore
* fix(c-page): restore it as it was, no c-pagination
* feat(pagination): tools/x-pagination demo
* fix(pagination): consistent border-radius
- components/c-page
- bootstrap4/pagination
- tools/x-pagination
* fix(pagination): consistent skip/etc links
* refactor(pag…): disabled/active links → modifiers
* enhance(pagination): disabled link for c-page
* fix(pag…): c-page should NOT use button class
* fix(pag…): list too tall, inconsistentent w/ x-…
* enhancepagination): consistent demos
* chore(pagination): mark all demos as ready
* fix(pagination): bootstrap discrepancy
* feat!: bootstrap4 WIP * fix(v3): nav bootstrap css load bugs * refactor(v3): Nav: Nav Tabs → Nav: Tabs * feat(v3): bs4 grid reorg * conf(v3): move subdir definition to subdir * feat(v3): distinguish global styles demo/set…/base * fix(v3): lost col demo styles * docs(v3): grid belongs in layout * fix(v3): grid css moved so update core-styles * docs(v3): move bs4 nav to bs4 components * docs(v3): figure belongs in content * docs(v3): order bs4 categogories * refactor(v3): move remaining bs4 patterns * docs(v3): match bootstrap 4 pattern naming * enhance(v3): hack to support tacc btns in modals * docs(v3): extra note about TACC modal button hack * refactor(v3): move all bs4 .postcss into child dir * fix(v3): user expects nav-tabs.css not tabs.css
wesleyboar
changed the title
Not a fix, because nothing was broken. Nothing broke, because Bootstrap4 is included in `core-styles.base.css`. Required in Bootstrap 3, because Boostrap 3 relies on _preview.css to load pattern stylesheet.
wesleyboar
added
major
TODO: Rename component to match Bootstrap 5 naming
I dunno. They work now. They are consistent. They are redundant. I am tired. I am done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Moved patterns into directories per client library — Bootstrap 3, Bootstrap 4, Bootstrap 5, Ant, TACC, etc. — and into child directories that mirror the client library's.
Status
(to make refactoring easier)
(consider adding alias "TACC/Core-CMS")
move
___.cssto___/___.cssadd
context:subdirto___/config.ymlchange label "(CMS|…) ___" to just "CMS|…"
Changes
_imports/___dir for each library___.cssto___/___.csscontext:subdirto___/config.ymldocs/upgrade-client.mdTesting
UI
2025-07-30