META: Framework TODO list

[th0ma7]

Also refer to python TODO list: #6619

General

• Avoid autotools type environment variable to leak into CMake and Meson (synocli-devel updates and republish for x25 nas #6877)
• Standardized boolean parsing: Introduce a shared helper Makefile for true/false/yes/no/1/0. Small change, but it levels out script behavior and avoids future confusion (framework: add standardized boolean parsing helper #6897)
• Review the toolchain downloads as DSM-6.1 is now on synology download archive (Toolchain misc fixes #6914)
• Migrate to using DSM-6.2.4 toolchains from our abandoned sources instead of sourceforge (@hgy59 ?)

Refactor

• Refactor toolchain using spksrc.toolchain directory (Toolchain misc fixes #6914)
• Refactor toolkit using spksrc.toolkit directory
• Refactor spk.mk using spksrc.spk directory

github-action

• Add Makefile standard validator part of github validation so our code follow same guidlines
• GitHub built-in AI reviews: Document how contributors can enable it, or integrate it as an optional reviewer in the workflow. Keep it opt-in and make sure it doesn’t block human review queues.
• Copilot question integration (i.e. such as ability to call /copilot action something within a PR): Evaluate what tvheadend did—maybe add a GH Issue/PR template section with a Copilot prompt or embed slash-commands. Focus on optional usage so we don’t disrupt existing flow. (Framework: Add AI assistant documentation for GitHub Copilot and coding agents #6896)
• Package auto-updates: Allow package update auto-PR (semver monitors, GitHub release polling, etc.). Even a first-pass script that flags outdated versions would be a huge productivity boost.

CMake

• remove legacy non-toolchain type build functionality
• remove RUN_CMAKE as no longer necessary (synocli-devel updates and republish for x25 nas #6877)
• find a way to avoid environment variable to leak in spksrc.depend.mk (theory: load minimal env early, specifc after dependencies) - ref. comment framework: Add CC/CXX and other build tools as Make variables in tc_flags #6908 (comment)
• fix duplicate rpath by removing set(CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE)
• Rename CMAKE_ARGS in favor of CONFIGURE_ARGS like meson and autotools
• Re-design the duplicate variable and workflow between spksrc.tc.mk and spksrc.cross-env.mk (namely TC_LOCAL_VARS_MK vs TC_VARS_MK)
• Don't rebuild $(WORK_DIR)/tc_vars.* at every dependency (although that's usefull for kernel modules)

Meson

• Remove RUN_MESON as no longer necessary (synocli-devel updates and republish for x25 nas #6877)
• Enable usage of build host cross-file (already exists as tc_vars.meson-native, just not used by default yet)

autotools

• Use LIBRARY_PATH and avoid -L flags in LDFLAGS (although keep for non GNU_CONFIGURE manual type builds)

media

• Basic ffmpeg vulkan enablement (requires v7.1 or higher) (Add vulkan support to ffmpeg #6867)

[th0ma7]

@mreid-tt @hgy59 Similar to the META python I've created this one to track general framework related framework changes we'd like to see in the future.

EDIT: @mreid-tt you'll notice that I've copied over some of your documentation you had created previously.

[th0ma7]

And forgot to mention - I cannot tackle them all, so you are more than welcomed to pick & chose if you have interest in any of these so we can keep the framework alive and pertinent and hopefuly facilitate package maintenance in the longer term 🚀

[hgy59]

Synology provides DSM 6.1 toolchains and I guess they will add DSM 6.2(.4) toolchains too?

[th0ma7]

Synology provides DSM 6.1 toolchains and I guess they will add DSM 6.2(.4) toolchains too?

@hgy59 I would not count on that... that's why i'm thinking it may be safer to copy them over to our lost+found sources?

[hgy59]

Synology provides DSM 6.1 toolchains and I guess they will add DSM 6.2(.4) toolchains too?

@hgy59 I would not count on that... that's why i'm thinking it may be safer to copy them over to our lost+found sources?

It is already here https://github.com/SynoCommunity/spksrc/releases/tag/toolchains%2Fdsm6.2.4

[mreid-tt]

hey @th0ma7, I've started on the second AI point above in #6896. The instruction included in the PR draws from our documentation and the inspiration in tvheadend (as suggested). It is somewhat opinionated so we should review the content before merging so we include all our relevant learnings we would like to train an AI on. Thus far it only includes my learnings from interacting with an agent on recent PRs so there is room for improvement.

[mreid-tt]

hey @th0ma7, I looked into what tvheadend is using for their AI code reviews on PRs. They have Gemini Code Assist installed, which is Google's free GitHub App.

Implementation Options:

Option	Cost	Setup
Gemini Code Assist	Free	Org admin installs GitHub App
GitHub Copilot for PRs	$19-39/user/month	Requires Copilot Business/Enterprise org subscription

What Gemini Code Assist provides:

• Automatic PR summaries
• AI-powered code reviews on every PR
• Ready-to-commit code suggestions
• On-demand assistance via PR comments (e.g., @gemini-code-assist review this function)

Example: See tvheadend PR #2043 for what the automated review looks like.

To enable: An org admin would install the app at https://github.com/apps/gemini-code-assist and select the spksrc repository.

The copilot-instructions.md from PR #6896 would help the AI understand our build system better, but isn't required for basic functionality.

Can you check if SynoCommunity has Copilot access at the org level, or should we proceed with Gemini Code Assist?

[mreid-tt]

hey @th0ma7, I've started the work for standardising the boolean parsing in #6897. Do let me know if this meets with your expectations for this task.

[hgy59]

@th0ma7 I can't remember the PR that updated/fixed the build*.log output.
But since then, the log files are lacking the log of the final targets when building an spk

like:

===>  Creating target installation dir of {package}
===>  Stripping binaries and libraries of {package}
===>  Generating service scripts for {package}
===>  Creating INFO file for {package}
etc.
until
===>  {timestamp} MAKELEVEL: 01, PARALLEL_MAKE: max, ARCH: {arch}-{tcversion}, NAME: {package} [END]
make[1]: Leaving directory '/spksrc/spk/{package}'

[th0ma7]

Yup, i noticed that last week... On my todo list