Skip to content

Commit b45901f

Browse files
committed
fix: add missing environment variables to smoke tests and fix image naming
1. Add missing MANAGED_DIMENSIONS_GRAPH environment variable to api-smoke.sh This variable is required by the API to start properly 2. Add missing AUTH_ISSUER environment variable to app-smoke.sh This variable is required by the app's nginx configuration script 3. Convert repository owner to lowercase in docker-build.yaml workflow Docker image names must be lowercase. The repository_owner variable contains "SwissFederalArchives" which causes "invalid reference format" errors when tagging images. Convert to lowercase using tr command. These fixes resolve the smoke test failures for all three components: - API: Missing environment variable MANAGED_DIMENSIONS_GRAPH - App: Missing environment variable AUTH_ISSUER - CLI: Invalid image reference format due to uppercase repository name
1 parent 31df4a6 commit b45901f

3 files changed

Lines changed: 4 additions & 1 deletion

File tree

.github/workflows/docker-build.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,8 @@ jobs:
111111
COMPONENT="${{ matrix.component }}"
112112
VERSION="${{ steps.version.outputs.version }}"
113113
ENV="${{ needs.prepare.outputs.environment }}"
114-
IMAGE="ghcr.io/${{ github.repository_owner }}/lindas-cube-creator-${COMPONENT}"
114+
REPO_OWNER=$(echo "${{ github.repository_owner }}" | tr '[:upper:]' '[:lower:]')
115+
IMAGE="ghcr.io/${REPO_OWNER}/lindas-cube-creator-${COMPONENT}"
115116
116117
# Save current latest as previous (for rollback)
117118
echo "old_latest_tag=${IMAGE}:${ENV}-latest" >> $GITHUB_OUTPUT

smoke-tests/api-smoke.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ CONTAINER_ID=$(docker run -d \
1111
-e SPARQL_ENDPOINT=http://example.com/sparql \
1212
-e S3_ENDPOINT=http://example.com:9000 \
1313
-e S3_BUCKET=test \
14+
-e MANAGED_DIMENSIONS_GRAPH=http://example.com/managed-dimensions \
1415
-p 3001:3000 \
1516
${IMAGE_TAG})
1617

smoke-tests/app-smoke.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ echo "🧪 Running App smoke tests for ${IMAGE_TAG}..."
77

88
# Start container
99
CONTAINER_ID=$(docker run -d \
10+
-e AUTH_ISSUER=https://example.com/auth \
1011
-p 8080:80 \
1112
${IMAGE_TAG})
1213

0 commit comments

Comments
 (0)