Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic SwatInc.Lis.Lis02A02 #5

Open
J4dJad opened this issue Oct 26, 2021 · 13 comments
Open

Generic SwatInc.Lis.Lis02A02 #5

J4dJad opened this issue Oct 26, 2021 · 13 comments
Assignees
Labels
enhancement New feature or request

Comments

@J4dJad
Copy link

J4dJad commented Oct 26, 2021

The problem here is that each time we need to adapte the classes - Fields- ( Patient Record , Result record....) to align with the Analyzer spec , but we know that all analyzers using the ASTM protocol are following the same standard means we can create a standard classes following the ASTM starandad, and manage the differences for each Analyzer on the Interface side ( DB or ConfigFile ) tu bypass the not used fields ( If else ).

@ibrahimhuycn
Copy link
Contributor

You are right on this. We need to delete all the branches and maintain a single master branch eh?

@ibrahimhuycn ibrahimhuycn added the enhancement New feature or request label Oct 30, 2021
@ibrahimhuycn
Copy link
Contributor

I will update this repo soon. Will need your valuable feedback.

@J4dJad
Copy link
Author

J4dJad commented Nov 3, 2021

Yes , i ll make the test on my side with the new changes , and align

@mgblackwater
Copy link
Contributor

mgblackwater commented Dec 6, 2021

Based on my experience, there are some differences between analyzers implementation even though they are following ASTM standards. I have implemented initially as a standard classes, but realized that doing this will make the code hard to change when there are new analyzers to integrate.

In the end, I am changing design to keep different packages/projects for individual analyzers by duplicating record classes. By using this design, I am hoping to make the code base to be extensible and easier to change for individual analyzers without impacting others.

I would try to contribute to this repo further if @ibrahimhuycn @J4dJad are considering my proposed design.

@ibrahimhuycn
Copy link
Contributor

Yeah, different manufacturers implement the standard differently so it's kinda difficult to maintain one driver for all. Sometimes the implementation is significantly different.

That's the reason the repo currently has multiple main branches.

My vision is to have separate drivers/dlls for each analyser and use them as plugins for the interface application. In that case, we'll just have to drop the driver dll file for the required analyser and it should work.

I'm not sure what you meant... do you have record types dublicated in the project specific for analysers?

Btw... I'm super open to contributions...

@mgblackwater
Copy link
Contributor

Yes, my design is to duplicate records in the corresponding projects of the analyzers.

The design is aligned with your vision to keep separate projects that can generate dll file to use in interface application.

@J4dJad
Copy link
Author

J4dJad commented Jan 17, 2022 via email

@hayder-1982
Copy link

HI DEAR
can you help how can me work this project

@ibrahimhuycn
Copy link
Contributor

HI DEAR can you help how can me work this project

do you still need help @lksgjsj ?

@hayder-1982
Copy link

hayder-1982 commented Dec 7, 2023

Yes i need.. can you send me your phone on WhatsApp.
@ibrahimhuycn

@hayder-1982
Copy link

🌹🌹🌹

@ibrahimhuycn
Copy link
Contributor

email me at [email protected]

@hayder-1982
Copy link

I send photo no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants