ghOSt: Deprecate custom CHECKs and use absl/log/check.h

This change deprecates the custom CHECKs in lib/logging.h and substitute
them with ones in absl/log/check.h.

PiperOrigin-RevId: 489331687

Author: dohyunkim-dev

BUILD

@@ -317,6 +317,7 @@ cc_library(
         "@com_google_absl//absl/debugging:stacktrace",
         "@com_google_absl//absl/debugging:symbolize",
         "@com_google_absl//absl/flags:flag",
+        "@com_google_absl//absl/log:check",
         "@com_google_absl//absl/memory",
         "@com_google_absl//absl/status",
         "@com_google_absl//absl/status:statusor",

WORKSPACE

@@ -31,12 +31,12 @@ http_archive(
 load("@rules_foreign_cc//foreign_cc:repositories.bzl", "rules_foreign_cc_dependencies")
 rules_foreign_cc_dependencies()
 
-# Abseil LTS 20220623.1
+# Abseil live HEAD (Nov 17, 2022)
 http_archive(
   name = "com_google_absl",
-  url = "https://github.com/abseil/abseil-cpp/archive/8c0b94e793a66495e0b1f34a5eb26bd7dc672db0.zip",
-  sha256 = "b9f490fae1c0d89a19073a081c3c588452461e5586e4ae31bc50a8f36339135e",
-  strip_prefix = "abseil-cpp-8c0b94e793a66495e0b1f34a5eb26bd7dc672db0",
+  url = "https://github.com/abseil/abseil-cpp/archive/ebab79b5783b3298ee2f31251174c660c322d7ef.zip",
+  sha256 = "c3b9d19cd38cd475f60b5756db1bdc6d10ed43e5c7ce7374eae9a57d763d0597",
+  strip_prefix = "abseil-cpp-ebab79b5783b3298ee2f31251174c660c322d7ef",
 )
 
 # GoogleTest release-1.12.1 (Jun 27 2022)

lib/logging.h

@@ -9,62 +9,12 @@
 
 #include <iostream>
 
+#include "absl/log/check.h"
 #include "absl/strings/str_format.h"
 #include "third_party/util/util.h"
 
 #if defined(GHOST_LOGGING)
 
-#define __LCHECK(op, invop, expr1, expr2)                                      \
-  do {                                                                         \
-    auto __val1 = expr1;                                                       \
-    auto __val2 = expr2;                                                       \
-    if (!(__val1 op __val2)) {                                                 \
-      int __errno = errno;                                                     \
-      std::cerr << __FILE__ << ":" << __LINE__ << "(" << ghost::GetTID()       \
-                << ") "                                                        \
-                << "CHECK FAILED: " << #expr1 << " " #op " " << #expr2 << " [" \
-                << __val1 << " " #invop " " << __val2 << "]" << std::endl;     \
-      if (__errno) {                                                           \
-        std::cerr << "errno: " << __errno << " [" << std::strerror(__errno)    \
-                  << "]" << std::endl;                                         \
-      }                                                                        \
-      ghost::Exit(1);                                                          \
-    }                                                                          \
-  } while (0)
-
-#define CHECK_EQ(val1, val2) __LCHECK(==, !=, val1, val2)
-#define CHECK_NE(val1, val2) __LCHECK(!=, ==, val1, val2)
-#define CHECK_LT(val1, val2) __LCHECK(<, >=, val1, val2)
-#define CHECK_LE(val1, val2) __LCHECK(<=, <, val1, val2)
-#define CHECK_GT(val1, val2) __LCHECK(>, <=, val1, val2)
-#define CHECK_GE(val1, val2) __LCHECK(>=, >, val1, val2)
-#define CHECK(val1) CHECK_NE(val1, 0)
-
-#ifndef NDEBUG
-#define DCHECK_EQ(val1, val2) CHECK_EQ(val1, val2)
-#define DCHECK_NE(val1, val2) CHECK_NE(val1, val2)
-#define DCHECK_LT(val1, val2) CHECK_LT(val1, val2)
-#define DCHECK_LE(val1, val2) CHECK_LE(val1, val2)
-#define DCHECK_GT(val1, val2) CHECK_GT(val1, val2)
-#define DCHECK_GE(val1, val2) CHECK_GE(val1, val2)
-#define DCHECK(condition) CHECK(condition)
-#else
-// `NDEBUG` is defined, so `DCHECK_EQ(x, y)` and so on do nothing.  However, we
-// still want the compiler to parse `x` and `y`, because we don't want to lose
-// potentially useful errors and warnings.
-//
-// (cribbed from ABSL_LOGGING_INTERNAL_DCHECK_NOP)
-#define GHOST_DCHECK_NOP(x, y) while (false && ((void)(x), (void)(y), 0))
-
-#define DCHECK_EQ(val1, val2) GHOST_DCHECK_NOP(val1, val2)
-#define DCHECK_NE(val1, val2) GHOST_DCHECK_NOP(val1, val2)
-#define DCHECK_LT(val1, val2) GHOST_DCHECK_NOP(val1, val2)
-#define DCHECK_LE(val1, val2) GHOST_DCHECK_NOP(val1, val2)
-#define DCHECK_GT(val1, val2) GHOST_DCHECK_NOP(val1, val2)
-#define DCHECK_GE(val1, val2) GHOST_DCHECK_NOP(val1, val2)
-#define DCHECK(condition) GHOST_DCHECK_NOP(condition, 0)
-#endif
-
 #ifndef GHOST_DEBUG
 #ifdef NDEBUG
 #define GHOST_DEBUG 0