Should isDynamicPattern be a replacement for is-glob?

[benmccann]

I thought it might allow us to get rid of some more dependencies, but it didn't seem to work when I tried swapping them. Not quite sure why the tests are failing, but you can see my attempt here:

benmccann/json-schema-to-typescript@2a79b10#diff-fa8d4e24d8399e8350f1c8bad05df53e8032ea995835bf911507015e2db61cddR5

[SuperchupuDev]

i can tell you better if you can provide a minimal repro

[benmccann]

It looks like isGlob returns false for undefined and isDynamicPattern crashes

[SuperchupuDev]

interesting. what does fast-glob do?

[benmccann]

throw new TypeError('Patterns must be a string (non empty) or an array of strings');

[SuperchupuDev]

i could make it return false on undefined, but would that be ideal for users?

[benmccann]

I think that's pretty reasonable behavior. If it's not a string then you're correctly returning that it's not a glob

[mrmlnc]

throw new TypeError('Patterns must be a string (non empty) or an array of strings');

JFYI: We did this because the pattern is always a string. Anything that is not a string is not a pattern by nature.

One of the interesting byways… we had a case where dozens of projects started to build incorrectly (local & CI) after updating the common library because undefined was passed to fast-glob due to an error, and fast-glob happily and silently returned []. It's a great time to debug :)