fix: no-wait-for-side-effects doesn't detect await expression

Closes testing-library#742

Author: StyleShit

lib/node-utils/index.ts

@@ -374,6 +374,10 @@ export function getPropertyIdentifierNode(
 		return getPropertyIdentifierNode(node.expression);
 	}
 
+	if (ASTUtils.isAwaitExpression(node)) {
+		return getPropertyIdentifierNode(node.argument);
+	}
+
 	return null;
 }
 

tests/lib/rules/no-wait-for-side-effects.test.ts

@@ -112,6 +112,16 @@ ruleTester.run(RULE_NAME, rule, {
             // Side effects are allowed inside .then()
             userEvent.click(button);
           })
+        `,
+			},
+			{
+				code: `
+          import { waitFor } from '${testingFramework}';
+          import { notUserEvent } from 'somewhere-else';
+          
+          waitFor(() => {
+            await notUserEvent.click(button)
+          })
         `,
 			},
 		]),
@@ -797,5 +807,19 @@ ruleTester.run(RULE_NAME, rule, {
 				],
 			} as const,
 		]),
+
+		...SUPPORTED_TESTING_FRAMEWORKS.flatMap((testingFramework) => [
+			{
+				code: `
+        import { waitFor } from '${testingFramework}';
+        import userEvent from '@testing-library/user-event'
+
+        await waitFor(() => {
+          await userEvent.click(button);
+        })
+        `,
+				errors: [{ line: 6, column: 11, messageId: 'noSideEffectsWaitFor' }],
+			},
+		]),
 	],
 });