Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error Handling: Process Exit Code is not checked after WaitForExit() #32

Open
mchubby opened this issue Dec 6, 2018 · 0 comments
Open

Error Handling: Process Exit Code is not checked after WaitForExit() #32

mchubby opened this issue Dec 6, 2018 · 0 comments
Labels
error handling Need more error handling

Comments

@mchubby
Copy link

mchubby commented Dec 6, 2018

Hi,
I have noticed that hactool invocations are not checked for a non-zero exit status code.
It happened when my provided keys.txt was unintentionally borked (e.g. incorrect key length).

It may also help to display what the commandline was when an error occurs.
@StudentBlake StudentBlake added the error handling Need more error handling label Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
error handling Need more error handling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mchubby @StudentBlake