refactor(web): replace Flow DS with shadcn Base UI#182
Conversation
|
add summary |
|
Can remove .npmrc |
yiningsoong
force-pushed
the
refactor/140-flow-ds-to-shadcn
branch
from
256ebb7 to
d0bb3e4
Compare
|
Need to do |
|
|
||
| const RootLayout: React.FC = () => { | ||
| const topbarRef = useRef<HTMLDivElement>(null); | ||
| const isWithinViewport = useIsWithinViewport(topbarRef); |
There was a problem hiding this comment.
Does the UX want fixed border bottom or disappear when scroll?
There was a problem hiding this comment.
I feel moving forward - we should use the prototype as the source of truth. Otherwise it's gonna be a painpoint to keep track on the verbal agreements - other engineers might change it to look like the prototype because they realised it looked different without knowing there was a separate thread all along 🤔
wdyt?
on the topic, checking with UXD on this and asking them to make the changes if necessary
There was a problem hiding this comment.
they liked the old implementation better so will be reverting LOL, made a note to them to change it on their end to keep it consistent
There was a problem hiding this comment.
I feel moving forward - we should use the prototype as the source of truth. Otherwise it's gonna be a painpoint to keep track on the verbal agreements - other engineers might change it to look like the prototype because they realised it looked different without knowing there was a separate thread all along 🤔
I think we will discuss this on next Monday to set the ways of working.
On mobile view, only the featured card has icon and description side by side. The rest of the cards' icon and description are top and bottom. |
yiningsoong
force-pushed
the
refactor/140-flow-ds-to-shadcn
branch
from
d0bb3e4 to
1b4b99c
Compare
we (uxd+me) decided to do 2 columns instead of 1 in mobile |
yiningsoong
force-pushed
the
refactor/140-flow-ds-to-shadcn
branch
from
fcce009 to
41ecf8a
Compare
3 participants
🚀 Summary
Replace the Flow Design System with shadcn/ui as the base component library, and add a /logos/ static file route to the Go backend so app logos are served
in production without relying on Vite's /public directory.
✏️ Changes
button, breadcrumb, separator, skeleton, and input primitives
🧪 Test Plan