minor changes

Author: Sammster10

build.gradle

@@ -23,8 +23,6 @@ dependencies {
     implementation 'com.zaxxer:HikariCP:5.1.0'
     implementation 'redis.clients:jedis:5.1.2'
     implementation 'net.staticstudios:static-utils:1.0.1'
-//    implementation 'net.staticstudios:static-messaging:1.0.0'
-
 
     testImplementation(platform('org.junit:junit-bom:5.10.3'))
     testImplementation('org.junit.jupiter:junit-jupiter')

src/main/java/net/staticstudios/data/DataManager.java

@@ -604,7 +604,7 @@ public <T> T get(DataKey key) throws DataDoesNotExistException {
         return (T) value;
     }
 
-    public <T extends UniqueData> T get(Class<T> clazz, UUID id) throws DataDoesNotExistException {
+    public <T extends UniqueData> T get(Class<T> clazz, UUID id) {
         Map<UUID, UniqueData> uniqueData = uniqueDataCache.get(clazz);
         if (uniqueData != null) {
             UniqueData data = uniqueData.get(id);
@@ -613,7 +613,7 @@ public <T extends UniqueData> T get(Class<T> clazz, UUID id) throws DataDoesNotE
             }
         }
 
-        throw new DataDoesNotExistException("UniqueData does not exist: " + id);
+        return null;
     }
 
     public void addUniqueData(UniqueData data) {

src/main/java/net/staticstudios/data/ValueSerializer.java

@@ -1,26 +1,20 @@
 package net.staticstudios.data;
 
-import java.lang.reflect.ParameterizedType;
-
 public interface ValueSerializer<D, S> {
     D deserialize(S serialized);
 
     S serialize(D deserialized);
 
-    @SuppressWarnings("unchecked")
-    default Class<D> getDeserializedType() {
-        return (Class<D>) ((ParameterizedType) getClass().getGenericSuperclass()).getActualTypeArguments()[0];
-    }
+    Class<D> getDeserializedType();
 
-    @SuppressWarnings("unchecked")
-    default Class<S> getSerializedType() {
-        return (Class<S>) ((ParameterizedType) getClass().getGenericSuperclass()).getActualTypeArguments()[1];
-    }
+    Class<S> getSerializedType();
 
+    @SuppressWarnings("unchecked")
     default D unsafeDeserialize(Object serialized) {
         return deserialize((S) serialized);
     }
 
+    @SuppressWarnings("unchecked")
     default S unsafeSerialize(Object deserialized) {
         return serialize((D) deserialized);
     }

src/main/java/net/staticstudios/data/data/UniqueData.java

@@ -55,15 +55,15 @@ public UniqueData getRootHolder() {
     }
 
     @Override
-    public boolean equals(Object obj) {
+    public final boolean equals(Object obj) {
         if (this == obj) return true;
         if (obj == null || getClass() != obj.getClass()) return false;
         UniqueData that = (UniqueData) obj;
         return Objects.equals(getId(), that.getId());
     }
 
     @Override
-    public int hashCode() {
+    public final int hashCode() {
         UUID id = getId();
         return id != null ? id.hashCode() : 0;
     }

src/test/java/net/staticstudios/data/DataManagerTest.java

@@ -9,4 +9,6 @@ public class DataManagerTest extends DataTest {
     //todo: test inheritance
     //todo: test value serializers
     //todo: test references
+
+    //todo: when inserting an FPV, if no explicit initial value was specified (ignore defaults), then if an entry already exists in the db/cache, do not change it. use the existing one.
 }