Fixed integer overflow issue

Author: pradnya-orchestral

apps/st2-actions/actions-details.component.js

@@ -199,7 +199,16 @@ export default class ActionsDetails extends React.Component {
     if(value < 0 || value > 2492000){
       return true
     }
+  }
 
+  isValidInt(value){
+        for (var n = 0; n < value.length; n++) {
+          var digit = (value.charCodeAt(n) >= 48 && value.charCodeAt(n) <= 57)   || value.charCodeAt(n) == 8;
+            if(!digit){
+               return true
+          }
+        }
+        return false
   }
 
   handleSection(section) {
@@ -228,7 +237,6 @@ export default class ActionsDetails extends React.Component {
   }
   handleRun(e, ...args) {
     e.preventDefault();
-
     return this.props.handleRun(...args);
   }
 
@@ -262,8 +270,10 @@ export default class ActionsDetails extends React.Component {
             <DetailsToolbar key="toolbar">
               <Button  disabled={ 
               (this.state.runValue && this.state.runValue.timeout &&  this.minMax(this.state.runValue.timeout)) || 
-              (this.state.runValue && this.state.runValue.limit &&  this.minMax(this.state.runValue.limit))  
-              }
+              (this.state.runValue && this.state.runValue.limit &&  this.minMax(this.state.runValue.limit))  || 
+              (this.state.runValue && this.state.runValue.timeout &&  this.isValidInt(this.state.runValue.timeout))  ||
+              (this.state.runValue && this.state.runValue.limit &&  this.isValidInt(this.state.runValue.limit))  
+            }
                 value="Run" data-test="run_submit" onClick={(e) => this.handleRun(e, action.ref, this.state.runValue, this.state.runTrace || undefined)} />
               <Button flat value="Preview" onClick={() => this.handleToggleRunPreview()} />
               <DetailsToolbarSeparator />

modules/st2-auto-form/fields/base.js

@@ -89,19 +89,6 @@ export class BaseTextField extends React.Component {
     const invalid = this.validate(value, this.props.spec);
 
     if(this.props.name === "timeout" || this.props.name === "limit"){
-      var status = true;
-      if(invalid) {
-        status = false
-      }
-        for (var n = 0; n < value.length; n++) {
-          var digit = (value.charCodeAt(n) >= 48 && value.charCodeAt(n) <= 57)   || value.charCodeAt(n) == 8;
-            if(!digit){
-               value = value.replace(/\D/g, "");
-          }else{
-
-            value =  value 
-          }
-      } 
       this.setState({ value, invalid }, this.props.onChange ? this.emitChange : undefined);
     } else{
       this.setState({ value, invalid }, this.props.onChange && !invalid ? this.emitChange : undefined);

modules/st2-auto-form/fields/integer.js

@@ -24,7 +24,11 @@ export default class IntegerField extends BaseTextField {
       return v;
     }
 
-    return v !== '' ? validator.toInt(v, 10) : void 0;
+    if(this.props.name === 'timeout' || this.props.name === "limit"){
+      return v 
+    }else{
+      return v  !== '' ? validator.toInt(v, 10) : void 0;
+    }
   }
 
   toStateValue(v) {
@@ -43,12 +47,15 @@ export default class IntegerField extends BaseTextField {
 
      if(spec._name === "timeout" || spec._name === "limit"){
       for (var n = 0; n < v.length; n++) {
-          var digit = (v.charCodeAt(n) >= 48 && v.charCodeAt(n) <= 57)   || v.charCodeAt(n) == 8;
+          var digit = (v.charCodeAt(n) >= 48 && v.charCodeAt(n) <= 57) || v.charCodeAt(n) == 45  || v.charCodeAt(n) == 8;
             if(!digit){
             return `'${v}'is non integer value`
            }else{
-            if(v > 2492000){
-              return `Entered value is not in valid range`
+             if(v < 0){
+              return `Entered value should be Min 0`
+             }
+            else if(v > 2492000){
+              return `Entered value should be Max 2492000`
             }else{
             v =  v 
             }