Skip to content

Commit acc07ef

Browse files
committed
Fixed shared code not showing on ccov-all reports
When collating the data from the individual runs, the only binary objects listed were for the test executables themselves. This was fine for statically linked code, but shared code is external to these, and wouldn't show up on the final reports. Thus, adding the executable's shared object links to the all target's `binaries.list` file fixed this.
1 parent 34e3aff commit acc07ef

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

code-coverage.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ function(target_code_coverage TARGET_NAME)
290290
COMMAND
291291
LLVM_PROFILE_FILE=${target_code_coverage_COVERAGE_TARGET_NAME}.profraw
292292
$<TARGET_FILE:${TARGET_NAME}> ${target_code_coverage_ARGS}
293-
COMMAND echo "-object=$<TARGET_FILE:${TARGET_NAME}>" >>
293+
COMMAND echo "-object=$<TARGET_FILE:${TARGET_NAME}>" ${SO_OBJECTS} >>
294294
${CMAKE_COVERAGE_OUTPUT_DIRECTORY}/binaries.list
295295
COMMAND
296296
echo

0 commit comments

Comments
 (0)