Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Implement MBPO algorithm #43

Closed
dtch1997 opened this issue Sep 27, 2021 · 3 comments
Closed

[Feature Request] Implement MBPO algorithm #43

dtch1997 opened this issue Sep 27, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@dtch1997
Copy link

dtch1997 commented Sep 27, 2021

Important Note: We do not do technical support, nor consulting and don't answer personal questions per email.
Please post your question on the RL Discord, Reddit or Stack Overflow in that case.

🚀 Feature

I would like to implement a model-based RL algorithm, MBPO proposed here.

Motivation

The proposed algorithm claims to be simpler and up to 10x as sample efficient as some other baselines like SAC.
This would be helpful in my own work too.

Checklist

  • [ x] I have checked that there is no similar issue in the repo (required)
@dtch1997
Copy link
Author

Original implementation is available here: https://github.com/JannerM/mbpo

@araffin
Copy link
Member

araffin commented Sep 27, 2021

Hello,
I've got mixed feeling about that one.
It would be interesting to have it, at least in a separate repo.
However, the current focus of SB3 is model free RL... and I hope this algorithm won't add too much complexity.
So, please give it a try and open a PR once you managed to reproduce results (please read and follow SB3 contrib CONTRIBUTING.md guide carefuly).
If it's too complex, we would still add a link to the implementation in our doc.

@araffin
Copy link
Member

araffin commented Oct 14, 2022

closing as out of scope of SB3 (we focus on model-free RL), however, if you want a model-free RL algorithm that is as sample efficient as MBPO, you can take a look at DroQ:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants