Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve utilities for tests with Rodos #341

Open
PatrickKa opened this issue Jan 12, 2025 · 0 comments
Open

Improve utilities for tests with Rodos #341

PatrickKa opened this issue Jan 12, 2025 · 0 comments

Comments

@PatrickKa
Copy link
Contributor

Description

Andriy wants a test summary at the end of a HW tests, where he sees at a glance if the whole test passed or failed. I think that that's a great idea, and we should extend it to print a summary of how many checks passed/failed in total. For this, we need to change Check() to log the total number of passes and fails and print the results at the end of the thread. An RAII class called Test would be a good option for that. Its constructor takes a title/description that it prints at the beginning, and its destructor prints the summary at the end.

Something similar should be implemented for the unit tests that require Rodos as well. Of course, it would be best to implement one thing that can be used in both cases, but I am not sure if that's feasible because the HW tests need to do some things in the threads init() function while the Rodos unit tests just implement RunUnitTest() which is then called by the unit test thread's run() method.

Finally, it would be nice to have Check() and Require() for both kinds of tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant