You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
hey this is Fábio from Balancer - very excited about brontes and looking forward to try it!
I thought about creating an issue to discuss / try to understand some things but maybe I can use this one. My first question is: doesn't brontes already have a Balancer V2 classifier for the functions you listed? 🤔 what I'm missing?
Besides, I would like to point out there are some swaps on Balancer V2 that are actually single-side add/remove liquidity - could that cause any issues? I don't see any handling for it but what happens is you have a swap where either token in or token out is the LP token itself and that probably shouldn't be classified as NormalizedSwap
Last, and very minor detail, but I think V2 pool registrations should be moved to discovery.rs? From a quick look other classifiers follow this and only Balancer is incosistent.
Protocol Name
Balancer
Protocol Description
Balancer Vault:
See: 0xBA12222222228d8Ba445958a75a0704d566BF2C8
Functions to Support
batchSwap()
flashLoan()
swap()
Normalized Action Types
NormalizedBatch
NormalizedFlashloan
NormalizedSwap
Is it a Proxy?
Discovery Mechanism Requirements
Unsure if necesary
Additional Context
See:
https://etherscan.io/address/0xba12222222228d8ba445958a75a0704d566bf2c8#code
Docs:
https://docs.balancer.fi/concepts/vault/#gas-efficient-batch-swaps
https://docs.balancer.fi/concepts/vault/swaps.html
Code of Conduct
The text was updated successfully, but these errors were encountered: