Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Pool fee #669

Open
0xvanbeethoven opened this issue May 22, 2024 · 0 comments
Open

Add support for Pool fee #669

0xvanbeethoven opened this issue May 22, 2024 · 0 comments
Labels
C-enhancement New feature or request D-2 Difficulty 2/5 (easy) P-1 Priority 1/3 (lowest criticality)
Milestone
Nerd Snipes

Comments

@0xvanbeethoven
Copy link
Contributor

0xvanbeethoven commented May 22, 2024 •
edited
Loading

Describe the feature

Add LP fee to the discovery so that we store AMM pool fees & use it to caclulate the pool fee on swaps.

You would need to add it to the disocvery, protocool Info & NormalizedSwap types.
@0xvanbeethoven 0xvanbeethoven added C-enhancement New feature or request S-needs-triage This issue needs to be labelled D-2 Difficulty 2/5 (easy) P-1 Priority 1/3 (lowest criticality) and removed S-needs-triage This issue needs to be labelled labels May 22, 2024
@0xvanbeethoven 0xvanbeethoven added this to the Nerd Snipes milestone May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement New feature or request D-2 Difficulty 2/5 (easy) P-1 Priority 1/3 (lowest criticality)
Projects
None yet
Milestone
Nerd Snipes
Development

No branches or pull requests
1 participant
@0xvanbeethoven