Skip to content

Commit cd40c50

Browse files
authored
3.0.0 Merge pull request #91 from SolidOS/newFace
Structure improvements
2 parents 2737d81 + 5db3037 commit cd40c50

File tree

10 files changed

+2670
-5170
lines changed

10 files changed

+2670
-5170
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ permissions:
99
on:
1010
push:
1111
branches:
12-
- "**"
12+
- main
1313
pull_request:
1414
branches:
15-
- "**"
15+
- main
1616
workflow_dispatch:
1717

1818
jobs:
@@ -23,7 +23,6 @@ jobs:
2323
strategy:
2424
matrix:
2525
node-version:
26-
- 18.x
2726
- 20.x
2827
- 22.x
2928

eslint.config.mjs

Lines changed: 35 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,39 @@
1-
import { defineConfig, globalIgnores } from "eslint/config";
2-
import globals from "globals";
1+
import globals from 'globals'
32

4-
export default defineConfig([globalIgnores(["src/**/*.test.js"]), {
5-
languageOptions: {
6-
globals: {
7-
...globals.browser,
8-
...globals.node,
9-
Atomics: "readonly",
10-
SharedArrayBuffer: "readonly",
3+
export default [
4+
{
5+
ignores: [
6+
'node_modules/**',
7+
'coverage/**'
8+
],
9+
},
10+
{
11+
files: ['src/**/*.js'],
12+
languageOptions: {
13+
globals: {
14+
...globals.browser,
15+
...globals.node,
16+
Atomics: 'readonly',
17+
SharedArrayBuffer: 'readonly',
18+
},
1119
},
1220

13-
ecmaVersion: 8,
14-
sourceType: "commonjs",
15-
},
21+
rules: {
22+
// Code style - match TypeScript settings
23+
semi: ['error', 'never'],
24+
quotes: ['error', 'single'],
1625

17-
rules: {
18-
"no-unused-vars": ["warn", {
19-
argsIgnorePattern: "^_",
20-
varsIgnorePattern: "^_",
21-
}],
22-
},
23-
}]);
26+
// Strict checking - match TypeScript strictness
27+
'no-console': 'warn',
28+
'no-unused-vars': 'warn', // Match TypeScript noUnusedLocals: true
29+
'no-undef': 'error',
30+
strict: ['error', 'global'], // Match TypeScript alwaysStrict: true
31+
32+
// Additional strictness to match TypeScript behavior
33+
'no-implicit-globals': 'error',
34+
'prefer-const': 'error', // Encourage immutability
35+
'no-var': 'error', // Use let/const only
36+
'no-redeclare': 'error'
37+
}
38+
}
39+
]

jest.config.js

Lines changed: 0 additions & 8 deletions
This file was deleted.

jest.config.mjs

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
export default {
2+
collectCoverage: true,
3+
coverageDirectory: 'coverage',
4+
testEnvironment: 'jsdom',
5+
testEnvironmentOptions: {
6+
customExportConditions: ['node']
7+
},
8+
setupFilesAfterEnv: ["./test/helpers/jest.setup.js"],
9+
transformIgnorePatterns: ["/node_modules/(?!lit-html).+\\.js"],
10+
roots: ['<rootDir>/src', '<rootDir>/test'],
11+
moduleNameMapper: {
12+
'^SolidLogic$': 'solid-logic',
13+
'^\\$rdf$': 'rdflib'
14+
},
15+
}

0 commit comments

Comments
 (0)