Skip to content

Conversation

@gary-van-woerkens
Copy link
Contributor

No description provided.

@gary-van-woerkens gary-van-woerkens requested a review from a team as a code owner July 24, 2025 16:09
@revu-bot revu-bot bot requested a review from revu-bot July 24, 2025 16:09
Copy link
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds production resource configuration for the API service. The configuration appears reasonable for a production environment, but there's a potential issue with memory allocation that could lead to resource inefficiency.

Comment on lines +6 to +8
requests:
cpu: 700m
memory: 2Gi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Memory requests and limits are identical (2Gi), which prevents horizontal pod autoscaling from working effectively. Consider setting requests lower than limits to allow for better resource utilization and scaling. For example, set memory requests to 1Gi to allow pods to scale based on actual memory usage while maintaining the 2Gi safety limit.

Suggested change
requests:
cpu: 700m
memory: 2Gi
requests:
cpu: 700m
memory: 1Gi

@tokenbureau
Copy link

tokenbureau bot commented Jul 24, 2025

🎉 Deployment for commit 97ca6f5 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/srdt/srdt/api:sha-97ca6f56d4308ad5ba33a9bb9fe8338500426662
  • 📦 docker pull harbor.fabrique.social.gouv.fr/srdt/srdt/web:sha-97ca6f56d4308ad5ba33a9bb9fe8338500426662
Debug

Copy link
Member

@rap2hpoutre rap2hpoutre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai pas trop d'avis (parce que je ne sais pas pourquoi on augmente) mais je n'ai rien contre !
Donc vous pouvez y aller !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants