-
Notifications
You must be signed in to change notification settings - Fork 0
fix: update prod resources #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
revu-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds production resource configuration for the API service. The configuration appears reasonable for a production environment, but there's a potential issue with memory allocation that could lead to resource inefficiency.
| requests: | ||
| cpu: 700m | ||
| memory: 2Gi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Memory requests and limits are identical (2Gi), which prevents horizontal pod autoscaling from working effectively. Consider setting requests lower than limits to allow for better resource utilization and scaling. For example, set memory requests to 1Gi to allow pods to scale based on actual memory usage while maintaining the 2Gi safety limit.
| requests: | |
| cpu: 700m | |
| memory: 2Gi | |
| requests: | |
| cpu: 700m | |
| memory: 1Gi |
|
🎉 Deployment for commit 97ca6f5 : IngressesDocker images
|
rap2hpoutre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'ai pas trop d'avis (parce que je ne sais pas pourquoi on augmente) mais je n'ai rien contre !
Donc vous pouvez y aller !
No description provided.