Skip to content

feat (sdk): support abort controller for SDK #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
forhad-hosain wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat (sdk): support abort controller for SDK #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions packages/sdk/src/LLM/Chat.class.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ class LocalChatStore extends SDKObject implements ILLMContextStore {
public get id() {
return this._conversationId;
}
constructor(private _conversationId: string, candidate: AccessCandidate) {
constructor(
private _conversationId: string,
candidate: AccessCandidate,
) {
super();
this._storage = new StorageInstance(null, null, candidate);
}
Expand Down Expand Up @@ -46,7 +49,11 @@ class LocalChatStore extends SDKObject implements ILLMContextStore {
class ChatCommand {
private _conversation: Conversation;

constructor(private prompt: string, private chat: Chat, private options?: PromptOptions) {
constructor(
private prompt: string,
private chat: Chat,
private options?: PromptOptions,
) {
this._conversation = chat._conversation;
}

Expand All @@ -57,7 +64,12 @@ class ChatCommand {
private async run(): Promise<string> {
await this.chat.ready;
await this._conversation.ready; //when we switch agent mode at runtime, we need to wait for the conversation to be ready
const result = await this._conversation.streamPrompt(this.prompt, this.options?.headers, this.options?.concurrentCalls);
const result = await this._conversation.streamPrompt(
this.prompt,
this.options?.headers,
this.options?.concurrentCalls,
this.options?.abortSignal,
);
return result;
}

Expand Down Expand Up @@ -151,9 +163,11 @@ class ChatCommand {
this._conversation.on(TLLMEvent.Data, dataHandler);

// Start the streaming process - don't await as we want to return the eventEmitter immediately
this._conversation.streamPrompt(this.prompt, this.options?.headers, this.options?.concurrentCalls).catch((error) => {
eventEmitter.emit(TLLMEvent.Error, error);
});
this._conversation
.streamPrompt(this.prompt, this.options?.headers, this.options?.concurrentCalls, this.options?.abortSignal)
.catch((error) => {
eventEmitter.emit(TLLMEvent.Error, error);
});
return eventEmitter;
}
}
Expand Down Expand Up @@ -187,7 +201,11 @@ export class Chat extends SDKObject {
public get agentData() {
return this._data;
}
constructor(options: ChatOptions & { candidate: AccessCandidate }, private source?: Agent | Record<string, any>, private _convOptions: any = {}) {
constructor(
options: ChatOptions & { candidate: AccessCandidate },
private source?: Agent | Record<string, any>,
private _convOptions: any = {},
) {
super();

const _data = source?.data || source || {};
Expand Down
1 change: 1 addition & 0 deletions packages/sdk/src/types/SDKTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ export type ChatOptions = {
export type PromptOptions = {
headers?: Record<string, string>;
concurrentCalls?: number;
abortSignal?: AbortSignal;
};

export enum Scope {
Expand Down