Matter AQS: Break AQS files further apart, add supported air quality sensor value handling #2587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcarter-775
requested review from
ctowns,
gharveymn,
greens,
nickolas-deboom and
tpmanley
|
Channel deleted. |
Test Results 71 files 477 suites 0s ⏱️ Results for commit c10b5ec. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against c10b5ec |
hcarter-775
commented
Dec 3, 2025
| @@ -0,0 +1,90 @@ | |||
| -- Copyright © 2025 SmartThings, Inc. | |||
Contributor
Author
There was a problem hiding this comment.
handlers unchanged, just moved
ctowns
reviewed
Dec 3, 2025
...rtThings/matter-sensor/src/sub_drivers/air_quality_sensor/air_quality_sensor_utils/utils.lua
Outdated
Show resolved
Hide resolved
ctowns
reviewed
Dec 3, 2025
...rtThings/matter-sensor/src/sub_drivers/air_quality_sensor/air_quality_sensor_utils/utils.lua
Show resolved
Hide resolved
...sensor/src/sub_drivers/air_quality_sensor/air_quality_sensor_handlers/attribute_handlers.lua
Outdated
Show resolved
Hide resolved
...sensor/src/sub_drivers/air_quality_sensor/air_quality_sensor_handlers/attribute_handlers.lua
Outdated
Show resolved
Hide resolved
| local conversion_function = fields.conversion_tables[from_unit][to_unit] | ||
| if conversion_function == nil then | ||
| device.log.info_with( {hub_logs = true} , string.format("Unsupported unit conversion from %s to %s", fields.unit_strings[from_unit], fields.unit_strings[to_unit])) | ||
| return 1 |
Contributor
There was a problem hiding this comment.
I realize this was existing code, but we might want to return nil and check this at the callsite, otherwise the capability would be emitted with a wrong value if 1 is returned
Contributor
Author
There was a problem hiding this comment.
gonna put up a separate PR for this promptly
Contributor
Author
There was a problem hiding this comment.
I think I'll wait for this guy to merge, then merge 2602 promptly afterwards.
Contributor
There was a problem hiding this comment.
TY! Just approved it.
...tThings/matter-sensor/src/sub_drivers/air_quality_sensor/air_quality_sensor_utils/fields.lua
Show resolved
Hide resolved
nickolas-deboom
approved these changes
Dec 3, 2025
Contributor
nickolas-deboom
left a comment
nickolas-deboom
left a comment
There was a problem hiding this comment.
LGTM! I might just recommend doing a quick smoke test on device if you haven't
ctowns
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Break subdriver files apart further to match what was done in Matter Camera and the Bilresa subdriver.
Further, adds support for setting the supportedAttributeValues on an infoChanged event.
Summary of Completed Tests
Unit tests updated. Tested on-device to ensure only correct values are populated