[Algorithm] Drain cache look up optimization, evaluate accuracy impacts #12
Labels
Algorithm
The work is on the algorithm side
analysis: log
enhancement
New feature or request
upstream
A issue that could be submitted to upstream repos first
Milestone
Now, @Liangshumin has a prototype to use cache look-up to speed up Drain significantly. I changed the lookup to after masking since
The algorithm sped up at least 40%, by reducing tree traversal almost to neglectable time. (then it's the divide and conquer the problem of masking task).
We should keep this optimization in mind and conduct further testing. If it's stable, we should probably contribute back upstream as it's a general purpose optimization.
This thread tracks our case by testing and theoretical evaluation in case unwanted side-effects emerge.
We also need to evaluate the choice of cache size to limit memory usage, it most likely should be near max_cluster limit.
The text was updated successfully, but these errors were encountered: