Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German Translation #2

Open
s8starie opened this issue Mar 17, 2020 · 0 comments
Open

German Translation #2

s8starie opened this issue Mar 17, 2020 · 0 comments

Comments

@s8starie
Copy link
Collaborator

The translation of the page in german is mostly finished.

Here are a few open issues (in order of importance):

  • the page needs to be proof read (a lot). It is likely that there exist both spelling mistakes and places which didn't get translated
  • Sometime the page displays messages received by the server. The server needs to be changed to send keys for the json file instead
  • The json file for the english translation is incomplete
  • Some dialog headers and placeholders got removed, since I did not know how to load their text from the json file
  • The input type file text of the documents tab did not get translated, since changing the text seems to be complicated (see issue Changing the text of an <input type = "file /> element #1)
  • Some text had to be changed to work in both german and english. Example:
    updateTips(tipID, "Length of " + fieldName + " must be between " + min + " and " + max + " characters.");

If anyone has a solution for those points feel free to tell (or directly implement it)

Translation the page was done as follows:

  • A json file inside the 'langs' folder contains the entire text in the format. The key is the english text (or a succinct translation of the text) and the value is the german text
  • Static html elements that contain text receive the following attributes:
    class="text-container" data-text-section =
    data-text-elem=
    this changes the text to the german version
  • For text generated by scripts one can use : window.languageData[
    ][] to get the corresponding text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant